search

WindowTop / WindowTop-App

Set window on top, make it dark, transparent and more
Other
1.12k stars 68 forks source link

[Shrink/PiP + Mouse Interact] - Implement feature to show where exactly is the mouse in the bigger preview #249

Closed gileli121 closed 2 years ago

gileli121 commented 2 years ago

Here are some very first recordings of this implementation

https://user-images.githubusercontent.com/17680514/179103970-c8fe75b8-0535-48c5-993e-3d9899b3242a.mp4

You get the idea. But instead of a red box, it will show the mouse cursor

gileli121 commented 2 years ago

After a few hours:

https://user-images.githubusercontent.com/17680514/179129402-b87446e6-c9e4-4200-b5bf-01acd02ca849.mp4

gileli121 commented 2 years ago

v5.16.0-beta2

Mystqr4 commented 2 years ago

Mouse preview on hover still not working on 5.1.6.beta 2

Edit: Mouse hover works with the option of "show original window" enabled but not without.

One thing I will mention about the new feature is that the hover preview window with "show original window" is great and all but the hover preview tends to go off screen and I can't see my mouse or the rest of the preview as it goes outside of my monitors view if that makes sense.

I will send you the files now.

gileli121 commented 2 years ago

@Mystqr4 We will do the regular process I do with most of the users. You will send me the settings file and using your settings I should reproduce the issue in most cases (unless there is something outside like system configuration)

Please do the following:

  1. Go to: %appdata%/windowtop image
  2. Send me these files to email gileli121@gmail.com image

I am asking to send it in email in private because the settings contain the activation key and it should not be public.

Mystqr4 commented 2 years ago

edited my post a few moments after you replied.

I will email you the files in a few moments

gileli121 commented 2 years ago

@Mystqr4 I think that I reproduced it. If you will resize the shrink box/ pip window to smaller, it will work, right?

Seems that you changed the configuration here: image

this is while you did not change this option: image

What it means is that the bigger preview will show up when the size of the PiP window is 120dp or below. But in the first configuration, you set the default size to 158dp so it will not show the bigger preview from the start. You need that second configuration will also be 158dp or higher.

May I ask how do you think to call these options in case their meaning is not clear?

About the other issue that it goes out of the screen, I fixed it and also some other issues.

Please try beta 3

Thank you.

Mystqr4 commented 2 years ago

Oh that explains it. I made the adjustments now and that seemed to have fixed it. I think the terminology is fine maybe a little red text that appears when the user makes adjustments under the "Default Shrink box size" warning people to make adjustments to the "maximum shrink box size for mouse hover too"

It makes perfect sense to me now that you pointed it out. I should have taken note as soon as I made those changes, I imagine most people would have too.

gileli121 commented 2 years ago

@Mystqr4 Great. Thanks for the feedback. So now everything is ok also with this new feature? May I ask how you write the text of the note?

Mystqr4 commented 2 years ago

Great work! It looks like everything is working as it should as far as I can tell. The new feature seems to be refined and working well also.

I don't know, maybe something like: WARNING! Please make adjustments to the maximum shrink box size to compliment the "Default Shrink box size" to avoid issues.

Or

WARNING! Please make adjustments to the maximum shrink box size to compliment the current settings.

gileli121 commented 2 years ago

Thank you for your efforts in testing the new functionality! OK, thanks for the feedback. I will add this small improvement in the settings in the final v5.16 release :)

Mystqr4 commented 2 years ago

Thank you for your efforts in testing the new functionality! OK, thanks for the feedback. I will add this small improvement in the settings in the final v5.16 release :)

Thanks for the development efforts and implementing so many great features. I will keep testing this software and provide as much feedback as possible where I can to help things along.

gileli121 commented 2 years ago

@Mystqr4 Thank you! After more thinking about it, in some cases, I did not like the way that the bigger preview was located and when it overlaps the smaller preview and moves with my mouse.

I decided to change a little how the position is calculated. Now when INTERACT mode is enabled, the bigger preview will not move and be located as shown here:

https://user-images.githubusercontent.com/17680514/179383990-359ea260-1701-4240-8894-a4cf53f7e4d5.mp4

The cloned mouse pointer was fixed a little. Now it will not look too upscaled

https://user-images.githubusercontent.com/17680514/179384001-95f2a603-34ef-4cd5-966f-b35a86b89f25.mp4

I am almost finished. In the next beta release, I plan to call this "Read mode" under the INTERACT settings and you will have the option to disable/enable it by default.

Here is beta 4 release:

Mystqr4 commented 2 years ago

Nice update! It's working pretty great and a lot better imho. The only thing that I could maybe add would be if the preview could be made to maybe not cover the taskbar. Working pretty great!

I have however noticed that when you shrink notepad.exe and enable interact mode it will be impossible to move the window as it will just begin to highlight the text instead, once interact mode is disabled you can move the window around manually again. This is the only one that I have noticed it doing it with so far.

gileli121 commented 2 years ago

@Mystqr4 Great to hear! About the dragging issue, you should be able to drag it by the title bar if you did not disable it in the settings: shrink_drag

Mystqr4 commented 2 years ago

Oh, I did disable that option in the settings and might look at putting that back on perhaps. Coincidentally I had no problems moving notepad++ (which you're using in the example) without the need for extra title bar.

gileli121 commented 2 years ago

@Mystqr4 Released in v5.16 https://github.com/BiGilSoft/WindowTop/releases/tag/v5.16.0

Mystqr4 commented 2 years ago

Thank you. I am currently testing this version. I have noticed that my toolbar still says shrink rather than PiP but that doesn't bother me at all but I thought I would mention it. It could be a consequence of me being on a beta release prior.

I had to laugh because the in build update check didn't tell me there was a new release again so I just manually updated.

gileli121 commented 2 years ago

It is a known issue. These beta builds are also v16.0 so they can't trigger the update notification

Mystqr4 commented 2 years ago

It is a known issue. These beta builds are also v16.0 so they can't trigger the update notification

Understood. Makes perfect sense now.

Just for consistency is the "Shrink" to "PiP" term going to be present throughout the settings and examples also. I'd imagine it would be less confusing for a new user to see the term Shrink in some places and PiP in others.

I have noticed a few other things but I should probably make another post for those.

gileli121 commented 1 year ago

@Mystqr4 In the last update that was released a few weeks ago, I renamed "Shrink" to "PiP" in all areas