WindowTop / WindowTop-App

Set window on top, make it dark, transparent and more
Other
1.1k stars 70 forks source link

PiP (Picture-in-Picture) - Implement a two-click method to enable it quickly like how it has done in Linux Elementary-OS #313

Closed gileli121 closed 10 months ago

gileli121 commented 1 year ago

After finishing implementing the crop function (#133) for the PiP (Picture in Picture) feature, we can add a method to run this function, as shown in Linux-based OS - Elementary OS, and demonstrated in the following video and article: https://www.youtube.com/watch?v=TtPxix5qIcM https://averagelinuxuser.com/picture-in-picture-elementary/

In this proposal, you can quickly enable the PiP and the Crop functions while "Show original window" is enabled, and you do it by simply pressing a hotkey, then selecting a region, and that's it. After that, you basically get to the point.

In the implementation of https://github.com/WindowTop/WindowTop-App/issues/133#issuecomment-1522081607 you can achieve it, but in extra steps:

  1. Enable PiP via toolbar/hotkey
  2. Enable "Show original window" (if disabled by default)
  3. Enable crop on the PiP preview using the toolbar and select the region
gileli121 commented 1 year ago

The task was recreated... I made some mistake... It got two votes before

gileli121 commented 1 year ago

Progress so far

Crop finish.webm

gileli121 commented 11 months ago

After 2 weeks of development, so far, it works well and looks good.

Cropping some text and typing.webm

Cropping and adjusting on the fly and controlling window.webm

Beta release

https://github.com/WindowTop/WindowTop-App/releases/tag/v5.22.0

The core feature was developed. I only left with minor stuff in settings for the feature.

You can feel free to try.

gileli121 commented 11 months ago

New development

Showing how we can adjust the crop from the native window in addition to the PIP window.webm

Note: To use this feature, you need to activate the option "Show original window" via settings or via the toolbar here image

Included in Beta 3 from here

https://github.com/WindowTop/WindowTop-App/releases/tag/v5.22.0

gileli121 commented 11 months ago

Bugfix

Fixed bug that when resizing the source window of the PIP view, the PIP view size and ratio were not updated to the updated size and ratio of the source window

Before

PIP - Fix source win resize - Before.webm

After (Fixed)

PIP - Fix source win resize - After.webm

Included in Beta 4 from here

https://github.com/WindowTop/WindowTop-App/releases/tag/v5.22.0

gileli121 commented 11 months ago

Development progress (Beta 5)

PIP + Crop can be enabled on an admin window:

You can enable crop on an admin window without running WindowTop with admin privileges. Once you start activating the crop, the OS will prompt for admin privilege permission. (Note: The admin privilege request prompt was not recorded due to issues with the recorder application.)

PIP with Crop - Showing an example of enabling PIP with Crop on Admin window.webm

Bugfixes

Included in Beta 5 from here

https://github.com/WindowTop/WindowTop-App/releases/tag/v5.22.0

gileli121 commented 11 months ago

Development progress (Beta 6)

Improvments

• Global exception handler - added more information in the error window ![image](https://github.com/WindowTop/WindowTop-App/assets/17680514/28e630cf-af81-4c33-a087-ad46da45a469)

Bugfixes

Included in Beta 6 from here

https://github.com/WindowTop/WindowTop-App/releases/tag/v5.22.0

gileli121 commented 11 months ago

Development progress (Beta 7)

Improvments

None

Bugfixes

Included in Beta 7 from here

https://github.com/WindowTop/WindowTop-App/releases/tag/v5.22.0

gileli121 commented 11 months ago

Development progress (Beta 8)

Improvments

None

Bugfixes

Included in Beta 8 from here

https://github.com/WindowTop/WindowTop-App/releases/tag/v5.22.0

gileli121 commented 10 months ago

Released