WindowTop / WindowTop-App

Set window on top, make it dark, transparent and more
Other
1.1k stars 70 forks source link

WindowTop often doesn't work on discord #320

Closed Vino4 closed 11 months ago

Vino4 commented 11 months ago

Hello friends :D

I love this product so much- it's literally exactly what I wanted for years so thank you so much <3

Issue

There's a bug which prevents me from putting discord into PiP mode

Steps

Expected

Actual

Notes

gileli121 commented 11 months ago

Thanks for the report. I am trying to reproduce

gileli121 commented 11 months ago

@Vino4 I see that the app detects the window (you have a toolbar). At least the login window.

Do I have to do all the other steps? Please make sure that the app is not excluded:

Go to image

Make sure that Discord is not listed here image

Or if it is listed, it can be listed only if "Whitelist the specified programs" is checked (and then WindowTop will ignore all other windows except this app and anything other than listed)

In addition, you may want to try v5.22-beta9 from here: https://github.com/WindowTop/WindowTop-App/releases/tag/v5.22.0

I made many changes and feature improvements for the PiP and the Crop in this version.

I noticed that beta 9 seems to be very stable now so it is probably one version before the final release of 5.22

Vino4 commented 11 months ago

Thank you for being super responsive @gileli121 ^^

Discord is not on the list (it's empty) and the list's mode is set to "Blacklist the specified programs" I logged out of discord and I can see the WindowTop bar on the login page and on the main discord app now- This issue seems to be specifically tied to something that happens when the other steps are done :)

I will download the beta and try it tomorrow when I have people around to test with :D

Vino4 commented 11 months ago

@gileli121 Just a little update for you:

Vino4 commented 11 months ago

Potentially helpful, additional info: I tried to shrink the subject window on 5.21.2 and got:

image
Vino4 commented 11 months ago

@gileli121 I just tested v5.22-beta9 beta and here are the results:

So as far as the hotbar issue goes, it's similar to v5.21.2, it's just refusing to show on this particular window :)

Vino4 commented 11 months ago

@gileli121 Now I'm seeing another issue (currently on v5.22-beta9)

image
gileli121 commented 11 months ago

@Vino4 Thanks, I hope to get to an investigation of it today. In the last two days, I have been working on improving the hotkeys configuration, fixing some bugs, and adding improvements that allow you to edit the main toolbar hotkeys from the toolbar page. The part in green was added:

image

I think that I will start working on this bug today.

gileli121 commented 11 months ago

I just reproduced it

Investigating

gileli121 commented 11 months ago

This is the problem.

Because the title is "" image

I probably did it as some kind of bad workaround for something that later solved properly.

I think that need to remove the "" condition.

gileli121 commented 11 months ago

Fixed

image

But I am wondering if somehow it can detect windows that it should ignore. The fix is to allow empty titles

gileli121 commented 11 months ago

Crop + PiP is working image

But title is indeed empty. I will add condition that if the title is empty, the PiP title will show the process name

gileli121 commented 11 months ago

But I am wondering if somehow it can detect windows that it should ignore.

Yes image

gileli121 commented 11 months ago

The simple fix was to keep using the _WINDOWTOP_INTERNAL_UI_ title. It was developed later but not used enough. After adding it to the Anchors and other UI elements, it works fine.

Now, it does not show the arrow above the anchors

gileli121 commented 11 months ago

I will add condition that if the title is empty, the PiP title will show the process name

Done.

image

The same condition also used by its Anchor (same issue was also there)

gileli121 commented 11 months ago

@gileli121 Now I'm seeing another issue (currently on v5.22-beta9)

  • When I crop a window that's being shared on a discord server-call (regardless of whether it's popped out or not), the entire cropped window turns grey
  • Uncropping it (if it's popped out) doesn't fix the video feed unless I pop it back in
  • Putting the window in PiP mode does the same thing
  • I've seen this happen in v5.21.2 only once when putting it PiP mode
  • This issue does not happen on other windows other than Discord's shared-screen window (example, a browser playing netflix)
image

Reproduced image

gileli121 commented 11 months ago

@gileli121 Now I'm seeing another issue (currently on v5.22-beta9)

  • When I crop a window that's being shared on a discord server-call (regardless of whether it's popped out or not), the entire cropped window turns grey
  • Uncropping it (if it's popped out) doesn't fix the video feed unless I pop it back in
  • Putting the window in PiP mode does the same thing
  • I've seen this happen in v5.21.2 only once when putting it PiP mode
  • This issue does not happen on other windows other than Discord's shared-screen window (example, a browser playing netflix)
image

Reproduced image

Fixed. Used the same hack from https://github.com/WindowTop/WindowTop-App/issues/146

image

gileli121 commented 11 months ago

Potentially helpful, additional info: I tried to shrink the subject window on 5.21.2 and got: image

This may happen less due to a fix in recent betas of 5.22

Improved app stability by removing almost all thread-locking mechanisms and replacing them with a less drastic approach. Freezing is now a very rare case.

You used 5.21

It is a different bug. now should not happen / less happen

gileli121 commented 11 months ago

@Vino4

Please try beta 11 from here:

https://github.com/WindowTop/WindowTop-App/releases/tag/v5.22.0

Let me know if all issues are resolved. And please try the INTERACT mode (you will see this button on the PiP view..) I want to know if it works fine with it. If so, I will add it to the default apps that interact is enabled by default.

The interact mode allows you to control the window via the PiP view.

Vino4 commented 11 months ago

@gileli121 Thank you so much!!!! I will test it tonight and report back 😁

Vino4 commented 11 months ago

@gileli121 I've tested v5.22.0 and everything is amazing!!!

Once again thank you so much for your amazing software!! I sincerely appreciate it and I have been actively recommending it to everyone I know since the moment I discovered it last month because it is SO GOOD!!!😁

gileli121 commented 11 months ago

@Vino4 Great to hear!

WindowTop is a secret software. Because I am nobody and not using the brand "Microsoft" (unlike PowerToys, which is also mostly developed by nobody people but uses the brand "Microsoft"...), you are not likely to hear about it every time a new feature is released. But this app's power is its quality level, and this is not my job to say. My job is to provide it. Users like you say it. So, this app is 100% promoted by users themself. No blogs, no YouTube videos, nothing. Only by users like you :) The business depends on users who spread the word.

If you try to compare the crop here with what they did, you will probably laugh a lot, or you won't believe it, and this is the point - the fact that famous bloggers talk about something doesn't necessarily mean that the product is good.

This world is made of fanboys, money, and interests so this is how it is. Don't expect it to be promoted by tons of bloggers just because it is good like you saying. I know what I am saying.

You and users like you need to spread the word :) This is probably one of the reason why the price is low