Windower / Issues

Windower Public Issue Tracker
31 stars 21 forks source link

Trusts: Lua runtime error: Unexpected character line 7 #1083

Open Millercan66 opened 2 years ago

Millercan66 commented 2 years ago

Downloaded Windower 4.3 stable version. Trust addon is useless. Checked the internet on how to fix problem, no luck. I'm not a coder I'm just a FFXI player. I don't understand the whole Lua thing but this problem has prevented me from saving trust sets, listing trust sets, and recalling them. If you could sent me instructions on how to fix this I would be grateful. gncmill@gmail.com.

The whole line in the BG console reads:

Trusts: Lua runtime error: libs/config.lua:99: XML error, line 7: unexpected character '#'.

Nifim commented 2 years ago

What is the name you tried to save the set under? it looks like you probably saved a set with a # in it and that is not a legal character for a set name. you can delete your settings file located in the addon/trust folder and then try saving the settings again using a simple name like ddparty or supportparty

RubenatorX commented 2 years ago

yeah, you corrupted your settings file by using special characters in your set name. keep it simple and it won't break itself

Millercan66 commented 2 years ago

Thanks, how do I get to said folder?

On Tue, Dec 28, 2021 at 7:33 PM Nifim @.***> wrote:

What is the name you tried to save the set under? it looks like you probably saved a set with a # in it and that is not a legal character for a set name. you can delete your settings file located in the addon/trust folder and then try saving the settings again using a simple name like ddparty or supportparty

— Reply to this email directly, view it on GitHub https://github.com/Windower/Issues/issues/1083#issuecomment-1002353944, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXCRMWURXIZ3EL5KCNENAXLUTJQQBANCNFSM5K5BMJHQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

RubenatorX commented 2 years ago

/path/to/windower/addons/trusts/data/settings.xml

z16 commented 2 years ago

This is really a config issue. It's not serializing special characters correctly, but it should. The XML library handles that case correctly, but the config library only uses that library to read settings, not to write them, because it wouldn't support keeping certain formatting structures (like comments).

To fix this, we would need to change a few lines in the nest_xml functions to escape the values they're formatting. It's not super trivial but can be done in a short ish time if someone wants to take a stab at it. Poke me if you want to and need some pointers.

ghost commented 1 year ago

im having this issue how do i fix this??

RubenatorX commented 1 year ago

im having this issue how do i fix this??

delete the addon's settings file and reload the addon, and don't use special characters such as < or > in your set names