Windows-Apps-Hub / UnitedSets

Bringing back Sets and Browser
https://www.microsoft.com/store/apps/9N7CWZ3L5RWL
MIT License
234 stars 10 forks source link

[Feature Request] - Setting tabs aside #9

Open Arpolend opened 1 year ago

Arpolend commented 1 year ago

Would be great to bring back this feature as well. No need to save the current states of apps, just launching them in one window would be enough.

GetGet99 commented 1 year ago

Do you mean set tabs aside feature like Microsoft Edge legacy?

GetGet99 commented 1 year ago
Arpolend commented 1 year ago

Yes I mean the Edge Legacy feature.

But Edge Legacy didn't hide the tabs, it saved them, you could turn the PC off and still restore them afterwards. There is a faithful copy of this feature as an extension for Chrome, you can check how it works: https://github.com/xfox111/TabsAsideExtension

So the two ways you described are the same. I just propose saving/restoring not only browser tabs but apps as well, i.e. the second option. Maybe even syncing them between devices like the aforementioned extension does.

For example, I create a school project and group a word document, some edge tabs and some unknown app. Then I set it aside for a month, can turn the PC off and etc. After that, pressing restore should open that exact document and those tabs, but for an unknown app it could just reopen it from scratch if saving its state was not possible.

GetGet99 commented 1 year ago

Oh sorry I forget how it works. Thanks for clarification. To make implementation easier, I think I will implement like this.

The reason I choose not to close window immedietly is that some apps are going to "hey, do you want to save your work" or something like that preventing closing window to be sucessful.

GetGet99 commented 1 year ago

Sorry accidentally pressed the button

GetGet99 commented 1 year ago

Implementation steps

Arpolend commented 1 year ago

That was also a problem in edge legacy, when websites wanted something saved, e.g. inking. Edge just set aside all other tabs and kept these. Not an elegant solution, but there is some logic.

Also a small thing: when setting group aside, it didn't hide the entire window, but left a "start page" tab so that you could easily switch between saved groups.

GetGet99 commented 1 year ago

I would say that the page when the app is opened with no tabs open to be "start page" for United Sets.

GetGet99 commented 1 year ago

Anyways, we plan to work on #12 first then we might take a look at this afterward. This is because the tab system is going to be changed internally, and the way to store data will also need to be implemented for those changes.

Implementation on #12 is expected to not take more than a week. Note: Even though I overestimated the time needed by a lot, I do not guarantee that statement.

GetGet99 commented 1 year ago

Good News! I finished implementing the first mockup. This does not save if you close and reopen the app.

https://user-images.githubusercontent.com/41405393/203991698-29857b6a-5738-4612-a1b5-f8a0e058fbc1.mp4

GetGet99 commented 1 year ago

However, in order for me to continue as I say, I need to implement #10 Therefore, I added "base feature for enhancement needed" tag, meaning that I will continue to implement this after #10 is implemented.

GetGet99 commented 1 month ago

Could be implemented soon since #47 was merged