search

Windows-XAML / Template10

Making Windows 10 apps great again
Apache License 2.0
1.41k stars 389 forks source link

WACK test fail after upgrade to Anniversary SDK (build 14393) #1165

Closed Chris-Marassovich closed 8 years ago

Chris-Marassovich commented 8 years ago

Hello,

I do a release build and WACK test on a regular basis during my development. You never know! :-) I allowed my VS 2015 update 3 to be applied along with the Windows 10 Anniversary SDK (build 14393). Since allowing those updates my app still runs in debug fine and does do a release build fine but fails the WACK on the prelaunch. Section from WACK results pasted below:

FAILED

App prelaunch

•Error Found: The app prelaunch validation detected the following errors:◦The app failed prelaunch test - 62323CMarassovich.membershipDB_2.0.0.0_x86__wxeygqgheeyfp.

•Impact if not fixed: The app will take a longer time to launch, even when prelaunch is enabled.

•How to fix: In the OnLaunched method implementation of the app, ensure you handle the LaunchActivatedEventArgs.PreLaunch option to be prelaunch event aware.

I am on T10 nuget 1.1.11 I thought this will possibly be fixed in the T10 nuget for the Anniversary update but then I thought best to raise this just incase.

Any advice is greatly appreciated as well as your time.

Cheers Chris ...

JWH89 commented 8 years ago

Hello all,

I'm having the same problem after updating the WACK tool / installing Update 3 for Visual Studio. I tried to rerun a WACK test with a previous app bundle(from a month ago). This also gave the same result as the above mentioned problem.

Any help on how to fix this would be greatly appreciated.

Update: I tried to upload my App-bundle(update) to the store and(thankfully!) it got accepted even though it failed the WACK test.

Kind regards,

JerryNixon commented 8 years ago

Well, this error with WACK has come back to haunt us. Perhaps the new WACK has changed how it measures prelaunch in the AU version. Let's see. Are you actually handling Prelaunch?

Chris-Marassovich commented 8 years ago

Good morning Jerry and thanks for your time and effort to respond.

Your comment on "AU Region":

  1. are you saying that the WACK will evaluate differently based on a region?
  2. You are not able to reproduce it?
  3. :-) Or are you having a dig at an Aussie? I believe your origins are Down Under also so I will take that Dig at me. :-)

NOTE: I hope you see the smiley faces on point 3 and see it for the fun it was meant to be. Text is so hard to get a joke across.

"Are you actually handling Prelaunch?" You guys are far smarter than I and I would never fiddle with stuff I do not understand. I do not understand Prelaunch so I have not touched it. My app uses the Hamburger template and I have very much left it stock with the exception of using EFCore and in the App.xaml.cs in the OnStartAsync I have the EFCore db.Database.Migrate() command. Very stock stuff I think.

I possibly did not make it clear in my first post but I run a release build/WACK often. Always before and after a major change (I have been caught out with another project). So my app passed the WACK before the SDK upgrade and right after the SDK upgrade it was failing on Prelaunch.

Just before writing this post response I did a new T10 Hamburger and release build and WACK and it is failing on Prelaunch.

It is good news from JWH89 that this does not seem impact the Store Submission.

I am happy to provide further information or testing as needed. Would like to state it again T10 and all you guys Rock!

Cheers Chris Marassovich

JWH89 commented 8 years ago

Apparently this is a known issue, got this from the MSDN forums:

This is a known issue with running the test on Win10 (1511) using the latest version of the SDK. If you use Win10 (1607) it should work correctly. If the app passes fine using that combination of the OS+SDK, then you can definitely ignore the Win10 (1511) results.

PS: I do not use the OnPrelaunchAsync, that is why I was confused it was giving this error.

FahadMustafa commented 8 years ago

Dev from down under as well, also getting this after upgrading to the latest SDK.

I am on Win10 1511 and T10 1.1.11 and not doing any special handling for prelaunch.

If I submit the app to the store will it go through ?

callummoffat commented 8 years ago

@Chris-Marassovich - not AU region, AU version. There is a new version of the SDK to work with the Anniversary Update. I don't quite understand the problem, though. I'm not handling prelaunch in my projects either, but I'm not experiencing this problem. I can't get the CK to fail the prelaunch test.

Are you using the latest version of T10?

Chris-Marassovich commented 8 years ago

@callummoffat - My mistake on the AU region :-) Saw AU and jumped to it being Australian settings. Oops sorry.

As I said in my original post the version of T10 I am using is the Nuget 1.1.11 version.

callummoffat commented 8 years ago

I'm not seeing this issue. I'm using the default OnPrelaunchAsync implementation, on the Anniversary Update SDK, with T10 v1.1.11. I get the full WACK pass (although, I am running the Anniversary Update, so that could be the reason).

WACK Test Results - Renttrack 0.3.9.pdf

Chris-Marassovich commented 8 years ago

@callummoffat - Just to be clear in your last sentence there are you saying your Win10 has been updated to the AU version? If so then that makes a little sense that the AU SDK works a little better for WACK testing on the AU version of the OS. :-)

I have seen lots of press on the AU version of the OS but very little detail on when we will get it. Fingers crossed when the AU OS update arrives it solves my issue.

Cheers Chris ...

callummoffat commented 8 years ago

Yes, my OS has been updated to the Anniversary Update. That must be it.

On Thu, Aug 18, 2016 at 12:24 PM Chris-Marassovich notifications@github.com wrote:

@callummoffat https://github.com/callummoffat - Just to be clear in your last sentence there are you saying your Win10 has been updated to the AU version? If so then that makes a little sense that the AU SDK works a little better for WACK testing on the AU version of the OS. :-)

I have seen lots of press on the AU version of the OS but very little detail on when we will get it. Fingers crossed when the AU OS update arrives it solves my issue.

Cheers

Chris ...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Windows-XAML/Template10/issues/1165#issuecomment-240589374, or mute the thread https://github.com/notifications/unsubscribe-auth/AM3pIznxwe4kPHLGR_47Bk1jLHIhYSzxks5qg6YqgaJpZM4Jfn6N .

Thanks,

Callum

Chris-Marassovich commented 8 years ago

Good morning everyone,

My PC has just updated the OS to the AU version and the WACK pre-launch fail now is a pass. So to summarise:

Thanks to everyone for helping and posting.

Cheers Chris ...

PS Not only is T10 a great tool but this repo and samples is making me a better developer. Thank you!

callummoffat commented 8 years ago

Just to note: post-AU preview builds will also pass certification when using the AU SDK.