search

Windows-on-ARM-Experiments / mingw-woarm64-build

Build script for Windows on Arm64 GNU cross compiler aarch64-w64-mingw32.
GNU General Public License v2.0
27 stars 3 forks source link

Refactor advanced.yml so that matrix strategy is moved to a parent workflow #132

Open Blackhex opened 4 months ago

Blackhex commented 4 months ago

Moves matrix strategy from advanced.yml up to a parent workflow called variants.yml calling the advanced.yml as reusable workflow. This refactor allows to run tests for other targets from the matrix. One caveat is that now the job graph does not look as nice as before.

Blackhex commented 3 weeks ago

@eukarpov Would you accept this change if individual workflows (one for each configuration) calling re-usable workflows would be used instead of the matrix? It would be less conscise and maintainable but the graph visualization would stay.

eukarpov commented 3 weeks ago

@eukarpov Would you accept this change if individual workflows (one for each configuration) calling re-usable workflows would be used instead of the matrix? It would be less conscise and maintainable but the graph visualization would stay.

My personal preference is to have good visualization. Sometimes I need to switch quickly between different PRs and custom CI runs. Good visualization helps to get quick summary about CI current progress. For the patch series it will be hard to understand what is happening when 1k+ jobs are executed.