search

Windows200000 / TwitchDropsMiner-updated

An app that allows you to AFK mine timed Twitch drops, with automatic drop claiming and channel switching.
MIT License
336 stars 17 forks source link

GitLocalize - emoji or unicode? #113

Open kilroy98 opened 2 months ago

kilroy98 commented 2 months ago

I changed the emoticons to Unicode because that's it maked in the English translation. https://github.com/Windows200000/TwitchDropsMiner-updated/blob/662711c012b61a9a12c46de48acc91274e241402/lang/English.json#L96-L98 https://github.com/Windows200000/TwitchDropsMiner-updated/blob/662711c012b61a9a12c46de48acc91274e241402/lang/English.json#L119-L125

And you merged changes like this in polish translation - https://github.com/Windows200000/TwitchDropsMiner-updated/commit/1c1203adac7a673907407ad886dadc985d0a7472

Windows200000 commented 2 months ago

@kilroy98

And you merged changes like this in polish translation

I merged them in Polish, because I wasn't thinking about it at that time, and it was a pull request, not allowing me to directly change it.

I think, in general, it would be better to have the actual emojis, so they are visible while translating.

The issue is that, as you said, it would be nice to have it consistent with English.json, but unfortunately, changing English.json would mark all affected translations as incomplete in GitLocalize, requiring quite a painstaking process of removing and adding all languages back manually.

There also might be a good reason why DevilXD uses unicode.

So, my main question would be:

Do you guys want to use Unicode or emojis directly? Why?

For added context, GitLocalize shows the emoji even if the file has Unicode. If you change the string that includes Unicode in GitLocalize, it changes the Unicode to an Emoji, which is how we ended up here.

kilroy98 commented 2 months ago

Maybe for inventory tab it's have sense to use emoji, but i never see when on main tab this emojes shows as colored.

Windows200000 commented 2 months ago

@kilroy98 There should be no difference at runtime, and when compiled, it might even be exactly the same.

The only difference is how it looks in the source file. While GitLocalize seems to continually want to convert it to the actual emoji and most editors support it, something like vim or other cli based editors will show � or □, because terminals often have a limited font, that doesn't include emoji.