search

Windows200000 / TwitchDropsMiner-updated

An app that allows you to AFK mine timed Twitch drops, with automatic drop claiming and channel switching.
MIT License
344 stars 17 forks source link

Maybe another hash has to be changed #156

Closed woctezuma closed 2 months ago

woctezuma commented 2 months ago

Problem

No response

Suggestion(s)

I have noticed a second hash was changed in the original repository. See the following commit:

To be compared to the current state of your repository: https://github.com/Windows200000/TwitchDropsMiner-updated/blob/69d73bec3acd91ce27418d3ccb93b3728a6ef3d5/constants.py#L302-L307

Additional notes

I have no idea whether this is important, but I mention it in case it is needed. For reference, you both changed another hash:

https://github.com/Windows200000/TwitchDropsMiner-updated/blob/69d73bec3acd91ce27418d3ccb93b3728a6ef3d5/constants.py#L308-L316

Windows200000 commented 2 months ago

It seems to run fine both with the new and the old one. I put it into in-dev for now and will speed up an update to master if I get crash reports. https://github.com/Windows200000/TwitchDropsMiner-updated/commit/642322006eea19623d096fe4d55736999b6f4765

Thanks for the help!

woctezuma commented 2 months ago

After reading this message, I realize the hash mentioned above may not have to be updated:

Indeed, it seems only one hash needed to be changed, and the hash mentioned above was a failed first attempt.

We will see.

Windows200000 commented 2 months ago

After reading this message, I realize the hash mentioned above may not have to be updated:

Indeed, it seems only one hash needed to be changed, and the hash mentioned above was a failed first attempt.

We will see.

The fact he got a new hash there still means this one is more likely to be supported, but as you said, it might also be fine.