Windows200000 / TwitchDropsMiner-updated

An app that allows you to AFK mine timed Twitch drops, with automatic drop claiming and channel switching.
MIT License
284 stars 15 forks source link

minor bug: scrolling in inventory tab works only partially on linux #65

Open ywwa opened 2 months ago

ywwa commented 2 months ago

Scrolling inventory tab using mouse wheel only works when pointer is over scrollbar element, otherwise nothing happens

Binary version: v15.5.0 (0f42b24) (AppImage)

https://github.com/Windows200000/TwitchDropsMiner-updated/assets/56758452/275c98bc-a846-42bf-b351-d78c245e643c

Windows200000 commented 2 months ago

Does this also happen when you set light theme and restart the app? If so, this is probably a thing in the original as well, otherwise I'll look into why the alt theme breaks it.

ywwa commented 2 months ago

Does this also happen when you set light theme and restart the app? If so, this is probably a thing in the original as well, otherwise I'll look into why the alt theme breaks it.

yes it is broken with light theme aswell

Windows200000 commented 2 months ago

Probably a thing that didn't work in the upstream repo either then. It works on Windows, so I don't know how I'd debug that. Maybe sometime in the future.

Thanks for reporting anyway, as existing issues will probably be carried over when this eventually merges if I don't manage to fix them.

Windows200000 commented 1 month ago

Affects both PyInstaller and AppImage

Windows200000 commented 1 month ago

I tried something, but this doesn't seem straight forward to fix. To avoid constantly pushing to in-dev with any change to get the builds, I would need to set a dev environment up on my Linux mint live image.

ywwa commented 1 month ago

@Windows200000 as you mentioned dev env on linux, build script may need an overlook.

https://github.com/Windows200000/TwitchDropsMiner-updated/blob/master/build.spec#L50C28-L50C72

this does not seem to work on all distros, atleast on arch linux its invalid path, to get build script working i had to modify build.spec to be like this instead

binaries.append((Path("/lib/libappindicator3.so.1"), "."))
Windows200000 commented 1 month ago

The real solution to this would be to use PATH to find it. I don't know how that would work with pyinstaller, but if you make it work feel free to share.