Open Valentin-Metz opened 1 month ago
Windows200000
commented
1 month ago Is it claimed on reload? I think this might be similar to #63, where I also experienced a drop not being claimed at first, because the miner thought it was mining another drop.
Valentin-Metz
commented
1 month ago Yes, a reload always claims (this is in fact, how I have temporarily bypassed the issue in my fork https://github.com/Valentin-Metz/TwitchDropsMiner/commit/07047a4309868f85c1f923bf2aed9c729528c9f6). It seems to be especially likely to occur on multi-stage campaigns.
Windows200000
commented
1 month ago I also don't know how I'd debug it, because trying something and then running the miner would immediately fix it. I also haven't even experienced this myself.
Valentin-Metz
commented
1 month ago The solution to this is probably adding a lot more logging statements (and maybe upgrading to / introducing a proper logging framework). I'll see if I can look into that over the coming days.
Windows200000
commented
1 month ago Hi, I released v15.6.0, can I get a confirmation that this is still an issue? I'm always running the latest in-dev to try and find bugs before releasing and have never experienced this.
dogodogowoof
commented
1 month ago I was able to complete and claim with your new release. I'll keep an eye and update you.
Edit: I am out of open campaigns, but it seemed to have done the job and completed 3 drops
rothexD
commented
1 month ago I was not able to make drop progress with the latest build (windows)
edit: after restarting the app multiple times its now working
Windows200000
commented
1 month ago @dogodogowoof @rothexD I'll leave it open. Again, I don't think much should've changed regarding this. I didn't specifically do anything to fix it, as I don't know what's wrong because I never had this issue.
Valentin-Metz
commented
1 month ago You'll probably only start running into it if a long, multistage campaign shows up. I'd assume it to still be there.
Windows200000
commented
4 weeks ago You'll probably only start running into it if a long, multistage campaign shows up. I'd assume it to still be there.
I had no issues with the whole last ow2 campaign.
Windows200000
commented
4 weeks ago So, I just happened to witness the end of a drop, and it did get stuck for a bit, but pretty quickly refetched and claimed without logging.
21:00:44: !!!required_minutes for "Wrest the Heart" is 0 This could be due to a subscription requirement, tracked in Issue #101!!!
21:00:49: Watching: QuickyBaby
21:01:01: Progress: 239/240 - World of Tanks, D-Day Token Store 2024: Weekend #1
21:02:03: Progress: 240/240 - World of Tanks, D-Day Token Store 2024: Weekend #1
21:02:24: Progress: 240/240 - World of Tanks, D-Day Token Store 2024: Weekend #1
21:02:38: Progress: 240/240 - World of Tanks, D-Day Token Store 2024: Weekend #1
21:02:41: !!!required_minutes for "Wrest the Heart" is 0 This could be due to a subscription requirement, tracked in Issue #101!!!
21:02:43: Watching: Teamkrado
21:02:54: Progress: 1/15 - World of Warships, Update 13.4 Drop: Week 4 updatedI guess there was some logic to claim when a drop is done and the thing fetching and thus claiming it for me might be a built-in fail-safe sort of thing.
edit: unfortunately running the exe and not vs code tho
Windows200000
commented
4 weeks ago So I ran it in CALL debug mode, but didn't find much. It just randomly decided to refresh, just before, again. I would probably have to add more debug logging to figure this out.
Valentin-Metz
commented
4 weeks ago Interesting traces. When I was running into the issue, it seemed to claim the previous drop when achieving a new drop at least.
Windows200000
commented
4 weeks ago This is a video of it happening, it weirdly does the last minute twice, and again, reloads out of nowhere (Maintanance task was supposed to be triggered at 23:36:32, not 23:23:39)
This has been an ongoing issue for a few weeks:
Drop progress is full, but no claim is triggered:
Full log output: