Windows81 / Roblox-Freedom-Distribution

A fork of the "Rōblox Filtering Disabled" project which allows people to host their own instances of Rōblox for other people to play. • “Roblox Filtering Disabled”项目的一个分支,它允许人们托管自己的Roblox实例,供其他人玩。
GNU General Public License v3.0
21 stars 4 forks source link

QOL feature, auto pull latest git release version. #3

Closed worships closed 1 month ago

worships commented 1 month ago

Automatically pulls latest versions, and supports for mirrors. Also modified the file names in the GameConfig example. Very simple QOL feature, can be modified to move the function in const.py somewhere else if needed.

Windows81 commented 1 month ago

Not bad for a first commit!

I see that the example paths are still absolute. I set my username on Windows as USERNAME, so the paths still wouldn't work on other systems.

Have you had the chance to test RFD yet?

worships commented 1 month ago

Yes! I have, also not my first commit, cause this is a new account, old one got banned, no reason why and github wont respond.

Anyways, thank you and yeah, I could just change it to be a more simple path and I get what you were going for, honestly you could just outright remove the file paths and put a comment.

Windows81 commented 1 month ago

I'll take that in.

Windows81 commented 1 month ago

I apologise for the reversal. I had to revert changes.

consts.py should only contains constants. I also doubt that RFD.exe can be updated in-place.

If I were to implement auto-update, I would:

For RFD.exe

Download the latest binary from GitHub and ask to overwrite the current one running. That will mean having to run a separate thread to install the new .exe and put it in place. Complex.

If running from source

Simply call git pull. Or download the latest .zip code archive.

What you can do

You're welcome to implement the downloading routine in ./launcher/downloader/. Any command-line interfacing will be done in ./launcher/subparsers/.

worships commented 1 month ago

Ah, its okay I totally understand, and yeah.

Windows81 commented 1 month ago

No problem. I just edited the comment above.