Closed worships closed 1 month ago
Not bad for a first commit!
I see that the example paths are still absolute. I set my username on Windows as USERNAME
, so the paths still wouldn't work on other systems.
Have you had the chance to test RFD yet?
Yes! I have, also not my first commit, cause this is a new account, old one got banned, no reason why and github wont respond.
Anyways, thank you and yeah, I could just change it to be a more simple path and I get what you were going for, honestly you could just outright remove the file paths and put a comment.
I'll take that in.
I apologise for the reversal. I had to revert changes.
consts.py
should only contains constants. I also doubt that RFD.exe can be updated in-place.
If I were to implement auto-update, I would:
RFD.exe
Download the latest binary from GitHub and ask to overwrite the current one running. That will mean having to run a separate thread to install the new .exe
and put it in place. Complex.
Simply call git pull
. Or download the latest .zip
code archive.
You're welcome to implement the downloading routine in ./launcher/downloader/
. Any command-line interfacing will be done in ./launcher/subparsers/
.
Ah, its okay I totally understand, and yeah.
No problem. I just edited the comment above.
Automatically pulls latest versions, and supports for mirrors. Also modified the file names in the GameConfig example. Very simple QOL feature, can be modified to move the function in const.py somewhere else if needed.