WindowsAppCommunity / WinAppCommunity.Sdk

Manage your membership in the Windows App Community.
MIT License
1 stars 1 forks source link

Refactor AppModels Nov 30, 2024 #4

Closed Arlodotexe closed 3 days ago

Arlodotexe commented 4 days ago

Background

See https://github.com/WindowsAppCommunity/WinAppCommunity.Sdk/issues/2 for background.

Problem

The AppModels must be updated according to the refined API spec.

Solution

We've split this analysis into two sections: Lists and properties. Each section lists what's extra and what's missing for each of the three types.


Lists:

Current setup

Publisher

Project

User


Changes to make:

[What's extra]:

Publisher doesn't need:

Project doesn't need:

User doesn't need:

[What's missing]:

Publisher is missing:

Project is missing:

User is missing:


Properties:

Current setup

Publisher

Project

User


Changes to make:

[What's extra]:

Publisher doesn't need:

Project doesn't need:

User doesn't need:

[What's missing]:

Publisher is missing:

Project is missing:

User is missing:


In addition to property and collection updates, several other changes should be made to the AppModel interfaces while we're in here refactoring things:

Arlodotexe commented 4 days ago

Continuing from here, I've identified a few common interfaces we'll be able to create:

For each item listed here, we'll need a modifiable and read-only version as previously spec'd: Read-only has get methods+events, modifiable has change methods.

Arlodotexe commented 4 days ago

Link and Role need to be migrated to an AppModel, as it only exists in Models right now.

Arlodotexe commented 3 days ago

Done in #5