search

WindowsLies / BlockWindows

Stop Windows 10 Nagging and Spying. Works with Win7-10
641 stars 97 forks source link

Significantly improved scanner of malicious updates. #24

Closed KOLANICH closed 9 years ago

rubo77 commented 9 years ago

This seems like a complete rewrite in WSH (Windows Script Host)

Can you please add a lot more documentation in the code, so everyone can easily inderstand what is happening (without having to learn WSH too deep)?

Also the Comments that explained the reason, why to remove the updates are missing in your code.

A lot has to be enhanced before this should be published: The code should be easily understandable

KOLANICH commented 9 years ago

Commented the code in doxygen short style.

rubo77 commented 9 years ago

Great work!

I didnt't try it out jet, but some more issues:

Maybe WSH could be a vulnerability itself?

KOLANICH commented 9 years ago

the part annalyzing the string starting with "get" needs some more explanation

It doesn't. It is everything clear. If WSH had at least ES5, everything would be implemented through setters/getters. But it doesn't.

config.js needs comments that explain what to configure here

config.js was meant to be config.json, but WHS js is built upon ancient ie engine and it doesn't have JSON. Adding a js-based parser is overkill here, that's why I use evil. But the config is still must be a valid json.

Any dependencies?

No dependencies except of WSH, ActiveX, used ActiveX components and my lib.

Maybe WSH could be a vulnerability itself?

We already have to use WSH, why not to use more WSH? WSH is a good technology, but strongly needs modernization. In fact i'd be better to replace it with node.js with bindings to .net and bundle node with windows.

KOLANICH commented 9 years ago

Forget about this PR, I have made something better https://github.com/KOLANICH/CleanUnwantedUpdates

But I haven't managed to integrate it here, because of the problems with paths. When I run my script manually, it works, when I put it into bat, it doesn't. Maybe you can?

rubo77 commented 9 years ago

Some hints for working in github

There's only one rule: anything in the master branch is always deployable.

  • never work in the "master" baranch of a fork of another project.
  • create a branch in your forked repository and work in this branch so you can commit your pull request from there

In your new project, you should openly state the problem, that it is not working jet in the README, or others will download it and notice too late, that it is not working still

KOLANICH commented 9 years ago

25