austin987
commented
5 years ago While I don't doubt there could be a bug, I don't see it. To reproduce, I used:wineserver -k ; rm -rf ~/.wine ~/.cache/winetricks/ahk/ ~/.cache/winetricks/mt4/ ; winetricks -q mt4
so it's a clean prefix and mt4/ahk aren't downloaded. I added some echos to see what the cwd is:
diff --git a/src/winetricks b/src/winetricks
index 4487aa5..d374089 100755
--- a/src/winetricks
+++ b/src/winetricks
@@ -1875,6 +1875,7 @@ _EOF_
w_ahk_do()
{
+ echo "start w_ahk_do value is $W_CACHE/$W_PACKAGE"
if ! test -f "$W_CACHE/ahk/AutoHotkey.exe"; then
W_BROWSERAGENT=1 \
w_download_to ahk https://www.autohotkey.com/download/AutoHotkey104805.zip c8bf1c3dc4622559963b6626316ba1d083bb8a8af605f78382e371e5294d435a
@@ -1890,6 +1891,7 @@ w_opt_unattended = ${W_OPT_UNATTENDED:-0}
$@
_EOF_
w_try "$WINE" "$W_CACHE_WIN\\ahk\\AutoHotkey.exe" "$W_TMP_WIN"\\tmp.ahk
+ echo "end w_ahk_do value is $W_CACHE/$W_PACKAGE"
}
# Function to protect Wine-specific sections of code.
@@ -13435,6 +13437,7 @@ w_metadata mt4 apps \
load_mt4()
{
+ echo "start mt4 value is $W_CACHE/$W_PACKAGE"
w_download https://web.archive.org/web/20160112133258/https://download.mql5.com/cdn/web/metaquotes.software.corp/mt4/mt4setup.exe?utm_campaign=www.metatrader4.com 96c82266e18cc4ada1bbc0cd0ada74c3a31d18914fb1a36626f4596c8bacb6f0 mt4setup.exe
if w_workaround_wine_bug 7156 "${title} needs wingdings.ttf, installing opensymbol"; then
@@ -13445,9 +13448,12 @@ load_mt4()
WINEDLLOVERRIDES="winebrowser.exe="
export WINEDLLOVERRIDES
+ echo "middle mt4 value is $W_CACHE/$W_PACKAGE"
# No documented silent install option, unfortunately..
w_try_cd "$W_CACHE/$W_PACKAGE"
w_ahk_do "
+ FileAppend, mt4/w_ahk_do value is %A_WorkingDir%, *
+ exit
Run, ${file1}
WinWait, MetaTrader Setup, license agreement
ControlClick, Button1
@@ -13458,6 +13464,7 @@ load_mt4()
Process, Wait, terminal.exe
Process, Close, terminal.exe
"
+ echo "end mt4 value is $W_CACHE/$W_PACKAGE"
}
#----------------------------------------------------------------running that (after WINEDEBUG=-all to reduce output), shows the cwd is set properly:
Using winetricks 20190310-next - sha256sum: 125f4a133beda72a8179372693af4eaac1bcb69c4a683d90b7e519880f13d1c9 with wine-4.5 and WINEARCH=win32
Executing w_do_call mt4
Executing load_mt4
start mt4 value is /home/austin/.cache/winetricks/mt4
Executing mkdir -p /home/austin/.cache/winetricks/mt4
Executing cd /home/austin/.cache/winetricks/mt4
Downloading https://web.archive.org/web/20160112133258/https://download.mql5.com/cdn/web/metaquotes.software.corp/mt4/mt4setup.exe?utm_campaign=www.metatrader4.com to /home/austin/.cache/winetricks/mt4
--2019-03-31 20:00:25-- https://web.archive.org/web/20160112133258/https://download.mql5.com/cdn/web/metaquotes.software.corp/mt4/mt4setup.exe?utm_campaign=www.metatrader4.com
Resolving web.archive.org... 207.241.233.214
Connecting to web.archive.org|207.241.233.214|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [application/exe]
Saving to: 'mt4setup.exe'
mt4setup.exe [ <=> ] 568.17K 773KB/s in 0.7s
2019-03-31 20:00:26 (773 KB/s) - 'mt4setup.exe' saved [581808]
Executing cd /home/austin/src/winetricks
------------------------------------------------------
Working around wine bug 7156 -- Meta Trader 4 needs wingdings.ttf, installing opensymbol
------------------------------------------------------
Executing w_do_call opensymbol
Executing load_opensymbol
Executing cd /home/austin/.wine/dosdevices/c:/windows/temp/_opensymbol
Executing ar x /home/austin/.cache/winetricks/opensymbol/fonts-opensymbol_102.2+LibO3.5.4+dfsg2-0+deb7u11_all.deb data.tar.xz
Executing tar -Jxf /home/austin/.wine/dosdevices/c:/windows/temp/_opensymbol/data.tar.xz ./usr/share/fonts/truetype/openoffice/opens___.ttf
------------------------------------------------------
Running /usr/local/bin/wineserver -w. This will hang until all wine processes in prefix=/home/austin/.wine terminate
------------------------------------------------------
Executing wine regedit /S C:\windows\Temp\_opensymbol\_register-font.reg
Executing cp /home/austin/.wine/dosdevices/c:/windows/temp/_opensymbol/_register-font.reg /tmp/winetricks.jjtPrNz9/_reg_27db49c0_21907.reg
Executing wine regedit /S C:\windows\Temp\_opensymbol\_register-font.reg
Executing cp /home/austin/.wine/dosdevices/c:/windows/temp/_opensymbol/_register-font.reg /tmp/winetricks.jjtPrNz9/_reg_7fd847b4_21907.reg
middle mt4 value is /home/austin/.cache/winetricks/mt4
Executing cd /home/austin/.cache/winetricks/mt4
start w_ahk_do value is /home/austin/.cache/winetricks/mt4
Executing mkdir -p /home/austin/.cache/winetricks/ahk
Executing cd /home/austin/.cache/winetricks/ahk
Downloading https://www.autohotkey.com/download/AutoHotkey104805.zip to /home/austin/.cache/winetricks/ahk
--2019-03-31 20:00:27-- https://www.autohotkey.com/download/AutoHotkey104805.zip
Resolving www.autohotkey.com... 2606:4700:20::6819:7810, 2606:4700:20::6819:7910, 104.25.121.16, ...
Connecting to www.autohotkey.com|2606:4700:20::6819:7810|:443... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location: https://www.autohotkey.com/download/1.0/AutoHotkey104805.zip [following]
--2019-03-31 20:00:27-- https://www.autohotkey.com/download/1.0/AutoHotkey104805.zip
Reusing existing connection to [www.autohotkey.com]:443.
HTTP request sent, awaiting response... 200 OK
Length: 2047047 (2.0M) [application/octet-stream]
Saving to: 'AutoHotkey104805.zip'
AutoHotkey104805.zip 100%[=====================================================================================================>] 1.95M 1.51MB/s in 1.3s
2019-03-31 20:00:28 (1.51 MB/s) - 'AutoHotkey104805.zip' saved [2047047/2047047]
Executing cd /home/austin/.cache/winetricks/mt4
Executing wine y:\ahk\AutoHotkey.exe C:\windows\Temp\_mt4\tmp.ahk
mt4/w_ahk_do value is Y:\mt4end w_ahk_do value is /home/austin/.cache/winetricks/mt4
end mt4 value is /home/austin/.cache/winetricks/mt4w_download will cd (to the cache directory), but it does a cd to the previous directory before it finishes. As you can see above, when w_ahk_do() runs, the CWD is ~/.cache/winetricks/mt4.
If you want set -x; you can use winetricks -v (though calling it directly with bash -x should also work). There's a small portion of the code that disables set -x (generating the metadata) which is superverbose, but if you want it, you can use -vv or --really-verbose.
In addition, the files are in their correct place in the cache:
austin@laptop:~/src/winetricks$ ls ~/.cache/winetricks/mt4/ ~/.cache/winetricks/ahk/
/home/austin/.cache/winetricks/ahk/:
AU3_Spy.exe AutoHotkey104805.zip AutoHotkey.exe
/home/austin/.cache/winetricks/mt4/:
mt4setup.exeNote: I'm not using docker. I don't see why docker would break things, but you may wan to try without docker to see what's different. In addition, make sure you're really using the latest winetricks (20190310-next)
kenorb
I'm using the latest
winetricks.I'd like to fix/improve the installation of MT4, however I've encouraged some bug in
winetricks.In
load_mt4()we dow_downloadthen_try_cd "$W_CACHE/$W_PACKAGE"right beforew_ahk_doin order to run${file1}.However first time when AHK is installed, on
w_ahk_doexecution, we're already in the wrong folder. We are in AHK folder, not in package one.Here are reproducible steps using Docker container:
docker run -it ea31337/ea-tester bash.wget https://raw.githubusercontent.com/Winetricks/winetricks/master/src/winetricks../eval.sh set_display(you can connect to it via VNC).DISPLAYby:export DISPLAY=:0.0.bash -x winetricks mt4.Relevant output:
Additional notes:
${file1}doesn't exist inahkfolder, but it exists inmt4(~/.cache/winetricks/mt4/).-x) at some point, so it's not clear what's going on.w_downloadjust beforew_try_cd, but it seems it didn't fix it.w_ahk_doit-self, changes the folder?w_ahk_dowith$file1in AHK script.