search

Winetricks / winetricks

Winetricks is an easy way to work around problems in Wine
GNU Lesser General Public License v2.1
2.78k stars 402 forks source link

Update physx #1550

Closed mirh closed 4 years ago

mirh commented 4 years ago

Putting aside that I'm not sure if you actually even need this in winetricks (maybe some dll has to be set to native or whatnot for CUDA acceleration to work in staging?) Version 9.14.0702 is just so old. You should offer latest one (and maybe legacy too, but idk).

austin987 commented 4 years ago

It was popular to use in some games around a decade ago (Mass Effect 2 and Bulletstorm come to mind, and looking at winetricks looks like Dragon Age, Darkness 2 and Unreal Tournament 3 all use it as well).

Do you actually have something that needs/uses the latest version? If not, I don't see any reason to update it.

mirh commented 4 years ago

Yes, I know what it was used for. I don't understand what you are gaining by sticking with an older version, if not bugs.

austin987 commented 4 years ago

Changing the version introduces the possibility of regressions. Not to mention that it then invalidates the cache for anyone that already has it downloaded, and takes developer time to do.

I don't mind doing that if there's actually a gain (i.e., it fixes an app). But doing it just for the sake of updating it doesn't make sense IMO.

mirh commented 4 years ago

?? Nvidia doesn't update stuff just because they think higher numbers looks cooler? (or nobody else other than browser vendors anyway, for as much as I know)

Now, I didn't personally have problems, but you can check all the changelogs to see why it matters.

austin987 commented 4 years ago

I didn't say nvidia updated for no reason. But the fact that you're proposing updating it, without knowing why it's even in winetricks, and without an example of a game or application that uses it, makes me wary.

mirh commented 4 years ago

At a quick glance, and after having checked how the staging patch works, I would guess it's in winetricks because at least once upon a time some game installer was borked, so you needed to install its dependencies separately. Idk how the situation is now - what I know is that physx is famous for pesky bugs that eventually just required updating.

mirh commented 1 year ago

This was actually fixed in #1796 and eventually #1879. But now that I think to it (I don't know what kind of idiot ball took me) adding legacy is really necessary. There are games that don't even start without it.