Winetricks / winetricks

Winetricks is an easy way to work around problems in Wine
GNU Lesser General Public License v2.1
2.78k stars 402 forks source link

Add options or restructure menu for use with Lutris #2038

Open testman42 opened 1 year ago

testman42 commented 1 year ago

Are there any plans to add improvements that will make winetricks more fitted for use in Lutris?

Maybe an option to skip the "Select the default wineprefix" step, as Lutris has each program in it's seperate wineprefix. So good step would be adding a command line parameter that assumes given prefix and directly shows the "What would you like to do in this prefix" menu.

there is part of winetricks --help that says this:

prefix=foobar         select WINEPREFIX=/home/user/.local/share/wineprefixes/foobar

which seems somewhat useful, but it is looking for prefixes in what, ${W_PREFIXES_ROOT} (which is defined as "${WINE_PREFIXES:-${XDG_DATA_HOME}/wineprefixes}"), so it is not that useful to Lutris, as that allows user to use prefixes from anywhere in the filesystem.

Maybe changing that option to take full prefix path would make sense? Or adding a new one called fullprefix= or prefixpath= or something like that.

austin987 commented 1 year ago

I'm not associated with Lutris, and I haven't seen any request from them regarding this, so, no, there is currently no plan for this.

That said, I'm very open to pull requests to improve integration with Lutris/other downstream projects, and the GUI in general.

austin987 commented 1 year ago

@strycore, any thoughts?

strycore commented 1 year ago

I have some plans to do the opposite, adapting Lutris to Winetricks. There are some issues with the fact that Winetricks uses Zenity, which is somehow linked to Webkit2 and can cause errors with our runtime. To avoid those issues, I'd like Lutris to be able to skip the Winetricks UI entirely and use its own. I'm going to run a script to inspect all Lutris installers and see which winetricks verbs are being used. Once we have this list, we can easily make a UI to present those verbs to the user, without calling the zenity GUI. In case we miss a verb that might be needed, there would be a free form text input where users can enter any Winetricks verb.