search

Winetricks / winetricks

Winetricks is an easy way to work around problems in Wine
GNU Lesser General Public License v2.1
2.82k stars 408 forks source link

# FIXME: update winetricks_is_installed to look at installed_file2..n #988

Open austin987 opened 6 years ago

austin987 commented 6 years ago

Mentioned above flash_metadata.

We should loop over a reasonable number of installed files instead of only checking 1. I'd say 25 is probably a safe limit, since a file existence check is pretty cheap and I doubt we'll ever need more than 5/10.

h1z1 commented 6 years ago

Can you elaborate a bit on what you mean here? Batch downloading or?

austin987 commented 6 years ago

@h1z1 no. winetricks_is_installed() checks if the file passed to it is present in the WINEPREFIX. This is used to check if a verb has already been installed and to check for success after installing.

This issue is about expanding that function to allow checking for more than one file in the prefix (as flash tries to do, but it's currently a no-op).