search

Winetricks / winezeug

Miscellaneous scripts/projects that are useful for wine developers, but don't belong upstream
11 stars 3 forks source link

Misc string improvements patch #146

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
This diff patch contains miscellaneous string improvements and corrections.

Mainly fixes typos and capitalization, etc.

Original issue reported on code.google.com by eldman...@gmail.com on 6 Aug 2010 at 4:09

Attachments:

GoogleCodeExporter commented 9 years ago 
Some more.

Original comment by eldman...@gmail.com on 6 Aug 2010 at 5:24

Attachments:

GoogleCodeExporter commented 9 years ago 
Even more.

Original comment by eldman...@gmail.com on 23 Aug 2010 at 4:25

Attachments:

GoogleCodeExporter commented 9 years ago 
Please submit changes as unified diff's, along with your real name and
a statement that you're licensing them under the LGPLv2.

Also, let's stick to user-visible changes; I don't think we want to fix
capitalization etc. in comments.

Original comment by daniel.r...@gmail.com on 23 Aug 2010 at 7:44

GoogleCodeExporter commented 9 years ago 
I did a change, then submitted the patch.
Then made some more changes later, then submitted a new patch.
That is why there are many diff files.

Also, these are not only fixes in comments, there are fixes for the printed 
output too.
Minor changes are a good way for a first-time contributor to get hands wet, 
then when I am more familiar with the codebase and submitting patches, I will 
make more advanced changes.

I would like to donate the code anonymously.
I do not claim copyright over the code.
I give it away for free. You can put it LGPLv2 or do what you want with it.

Original comment by eldman...@gmail.com on 24 Aug 2010 at 8:46

GoogleCodeExporter commented 9 years ago 
We cannot accept anonymous code contributions, we'll need a real name.

This applies to all the patches you sent, not just this one.

Original comment by austinenglish@gmail.com on 25 Aug 2010 at 6:51

GoogleCodeExporter commented 9 years ago 
My name is Fred Joseph Ladd.

I would like to donate the code.
I give it away for free. You can put it under the LGPLv2 or do what you want 
with it.
I do not need attribution, I donate it. You can have the rights to the code.

Original comment by eldman...@gmail.com on 25 Aug 2010 at 10:18

GoogleCodeExporter commented 9 years ago 
Patch is now unified.

Original comment by eldman...@gmail.com on 4 Sep 2010 at 3:25

Attachments:

GoogleCodeExporter commented 9 years ago 
Patch is now unified.

Original comment by eldman...@gmail.com on 4 Sep 2010 at 3:38

Attachments:

GoogleCodeExporter commented 9 years ago 
Patch is now unified.

Original comment by eldman...@gmail.com on 4 Sep 2010 at 3:40

Attachments:

GoogleCodeExporter commented 9 years ago 
I've merged the bits that seemed useful (especially that mwo=force typo, 
thanks),
but I'm not going to merge many capitalization changes for now,
nor add # in front of bug numbers; those kind of style changes don't
seem worth the bother.

There are bigger fish to fry, and churning the text can make it harder to
apply patches.

Original comment by daniel.r...@gmail.com on 4 Sep 2010 at 3:50

GoogleCodeExporter commented 9 years ago 
I would eventually like to see all the string patches merged.
I don't think it will make it any more difficult to apply patches.

They contain many more fixes, such as indention fixed.
Some of the apps in the menu (such as Apple Safari web browser, mwo=force, 
mwo=disable) is improperly indented, this is not visible in the GUI, but in the 
CLI it is end-user visible.

Windows is a name. Names should always have the first letter capitalized.
16 bit should be 16-bit.

Original comment by eldman...@gmail.com on 4 Sep 2010 at 5:19

GoogleCodeExporter commented 9 years ago 
Also I need these merged, so I can continue make further enhancement.

Such as reducing disambiguity by adding version numbers.
Example "7-Zip file archiver" to "7-Zip file archiver 4.65"

Original comment by eldman...@gmail.com on 4 Sep 2010 at 5:46

GoogleCodeExporter commented 9 years ago 
More standard behavior.

Original comment by eldman...@gmail.com on 4 Sep 2010 at 5:55

Attachments:

GoogleCodeExporter commented 9 years ago 
Also winetricks.patch does stuff such as change Accept-Encoding to be more 
compliant with the RFC.

http://tools.ietf.org/html/rfc2616#section-14.3

The RFC uses spaces after the comma.

Original comment by eldman...@gmail.com on 4 Sep 2010 at 5:59

GoogleCodeExporter commented 9 years ago 
If you have real fixes, please open a new bug for each one.
This one is closed.

Original comment by daniel.r...@gmail.com on 4 Sep 2010 at 6:04