Wingysam / Christmas-Community

Christmas lists for families
GNU Affero General Public License v3.0
245 stars 41 forks source link

feat. beta level group functionality #117

Closed jskiddie closed 9 months ago

jskiddie commented 9 months ago

I needed usergroups, so I added them. Please excuse my most likely bad coding style as this is my first time using Javascript. I have marked this as beta functionality as I am unsure wether or not it works perfetcly and is truly ready for production. I would love for others to try this out to determine if it works correctly I am very open to feedback. This implementation if far from Saas ready or anything close to that.

So what changed ?

Added beta group functionality:

How to enable

Setup

Misc

I stopped to do code cleanup, since it always broke it trying.

Wingysam commented 9 months ago

That's an impressive way to hack it in! I think this implementation makes maintaining the project difficult but I'd be happy for it to be a fork like Christmas-Community-with-Groups until I implement it how I want it.

Wingysam commented 9 months ago

I've closed this as it won't be merged into the main project. I'll add a link to your fork in the README until the main project has the feature.

jskiddie commented 9 months ago

I have done my best to seperate the fork thanks for mentioning it in the README. Do you think we will be able to migrate the data from the Fork to the normal version once you are finished ?

Wingysam commented 9 months ago

I don't think so, unless you can write some code to migrate your database schema to the new SQL schema. Maybe a migration script that iterates through all of the data and populates the database with it rather than an automatic migration?

jskiddie commented 9 months ago

Sounds like a possible and easy solution I will very likely implement. Especially because I suppose, I will have a migration script, that you will have created to migrate users, to start off from.