Wingysam / Christmas-Community

Christmas lists for families
GNU Affero General Public License v3.0
234 stars 41 forks source link

Migrate to SQLite #23

Open Wingysam opened 1 year ago

Wingysam commented 1 year ago

Christmas Community should use SQLite rather than PouchDB. This may fix #6.

ndlanier commented 1 year ago

As a suggestion, it may be beneficial to allow for an externally hosted sql database to be pointed to and disable whatever db is built in (whether that is sqlite or pouchdb) via an environment variable. This would allow for scalability and would also solve an issue with the helm chart. Currently via the helm chart, if you have to kick the pod/restart the container you need to replace the pod (so it terminates the pod before spinning up a new one) otherwise there will be access issues with the db because it's locked to the instance that is terminating and must wait till the lock is removed.

Wingysam commented 1 year ago

Technically you can specify an external CouchDB instance with DB_PREFIX but I don't think anyone does that. I think the migration should just fail if you have a custom DB server, since the feature is so obscure I doubt anyone that isn't me knows about it.

Re. external SQL server: