Wingysam / Christmas-Community

Christmas lists for families
GNU Affero General Public License v3.0
234 stars 41 forks source link

Remove Passport.js #25

Open Wingysam opened 1 year ago

Wingysam commented 1 year ago

Passport is unnecessary and overly complex. Tokens for users should be stored in the database, then should be validated during http request handling.

Wingysam commented 1 year ago

Depends on #23

LarsStegman commented 1 year ago

On the other hand it is nice that Password is used, because that makes it possible to use ldap (I'm using lldap). I want to start using this so my family doesn't have to create many separate accounts for the services I host on my Nuc.

Wingysam commented 1 year ago

I see the argument for this but I think it's less complex to implement this manually than to use passport.