Wingysam / Christmas-Community

Christmas lists for families
GNU Affero General Public License v3.0
247 stars 41 forks source link

hide/show progress bars #44

Open jordigh opened 1 year ago

jordigh commented 1 year ago

Progress bars are very visible at a glance. If your family members happen to look over your shoulder while you're working on Christmas lists, you may accidentally reveal to them how many gifts they're getting. Additionally, parents may want to log into their children's accounts for help and may not want to see their own progress bars from their children's accounts. Both situations have already happened in my family!

So, let's hide the progress bars by default and provide an easy button to show them.

Wingysam commented 1 year ago

Thank you! This is a good idea and should be done by default, but an environment variable should restore the original functionality. ALWAYS_SHOW_PROGRESS_BARS=true should remove the button and always show progress bars.

jordigh commented 1 year ago

There, like that?

Wingysam commented 1 year ago

Hey, sorry I haven't gotten to this yet. I've just gotten home from a fall retreat and need to catch up on homework. I'll review this when I can. Initial concerns are that the language definitions are still missing, and the env check should use the parse function of yes-no like this:

const { parse: yesNo } = require('yes-no')

Thanks!

Wingysam commented 1 year ago

These two strings should still be localized when visible. "???/???" might not make sense in some languages, and it might make more sense to have some kind of text in the "name " string. image image