Wingysam / Christmas-Community

Christmas lists for families
GNU Affero General Public License v3.0
212 stars 39 forks source link

Request: Add Sort Options To List Table #53

Open OneRadRedDad opened 1 year ago

OneRadRedDad commented 1 year ago

Next to the column headers, to sort by ascending/descending price, name, notes (or no notes), etc

Wingysam commented 1 year ago

What should the move up/down buttons do when you aren't sorting by selected order?

OneRadRedDad commented 1 year ago

That's a good point.

The first alternative that comes to mind would be a "sort by" option drop-down instead of the sortable column headers. But that would still require adding a priority number or something to each list item.

On Fri, Nov 25, 2022, 9:04 AM Wingy @.***> wrote:

What should the move up/down buttons do when you aren't sorting by selected order?

— Reply to this email directly, view it on GitHub https://github.com/Wingysam/Christmas-Community/issues/53#issuecomment-1327513420, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4MCTNY5PMO6QSOBB6PSCTDWKDBOBANCNFSM6AAAAAASK6M2DI . You are receiving this because you authored the thread.Message ID: @.***>

DatDanGuy commented 1 year ago

In addition to this, what about an easier method of moving the items further up or down, or categories even, or tags?

Wingysam commented 1 year ago

I'm not sure that it's necessary but I'd be willing to implement a PR to add drag/drop reordering.

DatDanGuy commented 1 year ago

Drag & drop reordering would be much appreciated!

dathbe commented 8 months ago

It seems to me there's a difference between how your own list should work and anyone else's you're viewing. If you're viewing your own list, you want the option to order things (probably priority order). And you're less likely to need to sort by, say, price. But if you're viewing someone else's list, it may be useful to sort by, say, price, and there's no reason you would need to reorder someone else's list.

Wingysam commented 7 months ago

Sorting by price is complicated because Christmas Community stores price as a text field, since someone might want to write "$5 each" or something, or use a different currency, or describe a price that isn't completely definite.