search

Wingysam / Christmas-Community

Christmas lists for families
GNU Affero General Public License v3.0
212 stars 39 forks source link

Docker image for ARM64 #58

Closed fdw closed 7 months ago

fdw commented 1 year ago

I wanted to try it out on a RasPi, but unfortunately, there is no Docker image for arm64. Does it not work there? Do you think you could add one? 🙂

Wingysam commented 1 year ago

Definitely need an image for arm64. Maybe I can use qemu to build for it on x86?

fdw commented 1 year ago

I've seen other projects use Docker buildx for cross-platform builds. Maybe that helps?

Kimbaras commented 1 year ago

Interested in this too!

Wingysam commented 1 year ago

I've been experimenting with building for arm64 from amd64 in another project today with success. Looking like I'll be able to do it here too!

Wingysam commented 1 year ago

Turns out it's incredibly easy to build arm64 images under WSL on x86 systems. This will definitely be happening at some point soon.

sebPomme commented 1 year ago

The image itself right now can directly be builded on raspi

Wingysam commented 1 year ago

Yeah it can be either built on arm hardware or you can use docker build --platform=arm64.

Kimbaras commented 1 year ago

Yeah it can be either built on arm hardware or you can use docker build --platform=arm64.

So basically starting from the Dockerfile present in the repo and using the "arm64" during the docker build process, is that right? Will try that as soon as possible.

Thanks!

Wingysam commented 1 year ago

Yes, this command works for me with Docker Desktop:

docker build . -t christmas-community --platform=arm64
fdw commented 12 months ago

Awesome, thank you! 🙂 Do you plan to publish it on Docker Hub or Github?

Wingysam commented 12 months ago

I've never pushed an image to GitHub before but I've been considering pushing to it over Docker Hub.

Kimbaras commented 12 months ago

I can confirm I was able to build and deploy the Docker image on a Raspberry Pi 4 (arm64).

Seems deploying / build on older Pis (3b+) is still a no go (tried to build with either arm32v6 and arm36v7 platforms but no results with either of those). But judging by the title of the issue, I believe this is a different topic :D

@Wingysam do you think you'll be able / willing to support also older Pis? If yes, I'll open a new issue dedicated to that, if not, I understand it.

Anyway, thanks for the support!

Wingysam commented 12 months ago

I'm not willing to test every release on older Pis to make sure I don't break it for them but I'll do what I can. What's the error trying to build on a 3b+?

Kimbaras commented 12 months ago

Sorry, my previous comment is kind of wrong.

I was able to build the image on older Pis, the container seems to start, but in the logs there is just a repeating error (haven't got it at hand right now, but it's a pretty generic error related to the arch I've seen in other softwares as well for similar situations, arm not supported and so on). Will get the error when possible, but again I think it's out of topic fir this, as from my point of view, right now it's owrking correctly on arm64

Wingysam commented 7 months ago

The arm64 build is now on Docker Hub!