Wingysam / Christmas-Community

Christmas lists for families
GNU Affero General Public License v3.0
212 stars 39 forks source link

Request: Allow adding multiples of an item #60

Closed OneRadRedDad closed 7 months ago

OneRadRedDad commented 1 year ago

The default item count can be 1, but what if someone wants 2 of something, or 4, or more?

Wingysam commented 1 year ago

This can be achieved by either adding multiple of the item or writing it in the note. Is there a good reason to increase complexity by adding a dedicated field for this?

OneRadRedDad commented 1 year ago

I think a separate column would keep the UI clean and would prevent a user from having to add too much to the Notes field

On Sat, Dec 10, 2022, 11:50 AM Wingy @.***> wrote:

This can be achieved by either adding multiple of the item or writing it in the note. Is there a good reason to increase complexity by adding a dedicated field for this?

— Reply to this email directly, view it on GitHub https://github.com/Wingysam/Christmas-Community/issues/60#issuecomment-1345304481, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4MCTN2NOI7RGKSNETKIZX3WMSYEXANCNFSM6AAAAAASQAXVS4 . You are receiving this because you authored the thread.Message ID: @.***>

Wingysam commented 1 year ago

Should the count field also multiply the price?

OneRadRedDad commented 1 year ago

Good question. Or what about just adding an "each" after the item price?

On Sat, Dec 10, 2022, 1:15 PM Wingy @.***> wrote:

Should the count field also multiply the price?

— Reply to this email directly, view it on GitHub https://github.com/Wingysam/Christmas-Community/issues/60#issuecomment-1345353352, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4MCTN74LYHABY2GUNLXH7LWMTCE3ANCNFSM6AAAAAASQAXVS4 . You are receiving this because you authored the thread.Message ID: @.***>

Wingysam commented 1 year ago

That would have to be localized but that could work, thanks.

oddstr13 commented 8 months ago

The only reason that I can think of for having a number field would be so that different people could pledge one each for example – this would complicate things quite a bit tho.

Wingysam commented 7 months ago

How should the UI for this look? Like say someone asks for 10 of an item and 9 different people have pledged one each, what should your screen look like?

dathbe commented 7 months ago

This is how Amazon handles it...basically comment bubbles: image Users could always add their own comments to their own lists ("I'd like 5 of these"), but then gift givers would not be able to easily mark how many they've pledged.

I could come up with a fairly convoluted UI that would indicate how many you are asking for and how many have been pledged. And then the pledge button would ask the giver how many they are pledging and allow the giver to un-pledge numbers.

But honestly, it's probably more straightforward to just add the item 5 times if you want 5 of them.

Wingysam commented 7 months ago

Yeah I think it's better to just duplicate the item.