Wingysam / Christmas-Community

Christmas lists for families
GNU Affero General Public License v3.0
294 stars 46 forks source link

Request: Ability to create multiple wishlists #61

Open OneRadRedDad opened 1 year ago

OneRadRedDad commented 1 year ago

So a parent can create a wishlist for their child, or two people can share an account (such as grandparents who might not be as tech savvy)

Wingysam commented 1 year ago

This doesn't work with the model of seeing someone's wishlist by visiting /wishlists/\<account name>. In the case of a child that isn't old enough to use the app, the parent can create an account for the child then use the "impersonate" feature to log in as them and add items.

In the case of grandparents, I think it might be best to create "permanent access links" that immediately log you in as a specific user, then you can give them this link somehow. In the case of my grandparents, I would text it to them so they could log in on their phone easily. In some cases, you could create a shortcut for them on their desktop, or a bookmark.

OneRadRedDad commented 1 year ago

Understandable about grandparents. I made a single account for my grandparents for now, and will instruct them to include who wants each item in the Notes field.

Re: Children-- what if that URL were reserved for the "default" wishlist for an account, and additional lists could be in /wishlists/// ?

As for impersonation, does that mean a parent would need to be an admin account? Is it possible to set it so certain accounts can only impersonate certain other accounts?

On Sat, Dec 10, 2022, 11:56 AM Wingy @.***> wrote:

This doesn't work with the model of seeing someone's wishlist by visiting /wishlists/. In the case of a child that isn't old enough to use the app, the parent can create an account for the child then use the "impersonate" feature to log in as them and add items.

In the case of grandparents, I think it might be best to create "permanent access links" that immediately log you in as a specific user, then you can give them this link somehow. In the case of my grandparents, I would text it to them so they could log in on their phone easily. In some cases, you could create a shortcut for them on their desktop, or a bookmark.

— Reply to this email directly, view it on GitHub https://github.com/Wingysam/Christmas-Community/issues/61#issuecomment-1345306071, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4MCTN3KNWTHQL4U2INEE5DWMSY5TANCNFSM6AAAAAASQH4LA4 . You are receiving this because you authored the thread.Message ID: @.***>

Wingysam commented 1 year ago

Yes, I assumed that the parent is also the admin. So the admin should be able to create a "sublist" under the parent's account which would have no secrecy features such as not being able to see what other people have added to your wishlist or what has been pledged?

OneRadRedDad commented 1 year ago

I don't think that's a perfect assumption. What if the service is hosted by a grandparent, or random cousin, or aunt or uncle, or family friend?

I think user-creatable sublists would be ideal. Then each user could decide whether to set secrecy settings per list

On Sat, Dec 10, 2022, 1:18 PM Wingy @.***> wrote:

Yes, I assumed that the parent is also the admin. So the admin should be able to create a "sublist" under the parent's account which would have no secrecy features such as not being able to see what other people have added to your wishlist or what has been pledged?

— Reply to this email directly, view it on GitHub https://github.com/Wingysam/Christmas-Community/issues/61#issuecomment-1345354038, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4MCTNZMK3WOQBT2SOA3PQDWMTCRHANCNFSM6AAAAAASQH4LA4 . You are receiving this because you authored the thread.Message ID: @.***>

Wingysam commented 1 year ago

Yeah that seems like the best way to go about this. I'll need to add per-wishlist settings in addition to sublists.

dominch commented 1 year ago

I'm also missing some kind of classification per user like:

having everything in one bucket is too simple

jskiddie commented 11 months ago

This doesn't work with the model of seeing someone's wishlist by visiting /wishlists/. In the case of a child that isn't old enough to use the app, the parent can create an account for the child then use the "impersonate" feature to log in as them and add items.

In the case of grandparents, I think it might be best to create "permanent access links" that immediately log you in as a specific user, then you can give them this link somehow. In the case of my grandparents, I would text it to them so they could log in on their phone easily. In some cases, you could create a shortcut for them on their desktop, or a bookmark.

How to create a permament access link ? and is there any documentation about ?

fdw commented 4 months ago

I'd like to support the original request for multiple wishlists. I would like to have different wishlists for different people/groups, because I don't want to share some things with my colleagues, for example.

If you can choose with whom you share a wishlist, this might even solve #128.

jskiddie commented 4 months ago

@fdw why not create multiple accounts for yourself and group them with the corresponding people ? (yes this requires grouping, which is already in consideration as per #7 )

fdw commented 4 months ago

That would be possible, but then I'd have to manage multiple accounts with multiple passwords and log in and out all the time. It feels a lot more comfortable (and natural) to log in only once and then manage multiple lists, moving items between lists and maybe having one list shared with no-one that serves as a feed for the other lists.

Wingysam commented 3 months ago

So you use Christmas Community with your coworkers? What does that look like?

fdw commented 3 months ago

That was just an example, but what I'd like to do with Wishlist is to collect books that could be interesting for my work and share that with (friendly) colleagues, so that they can recommend things they've read before or find interesting. But I'd still buy them myself.

But you can see how I wouldn't want to share my other lists with them 😉

Wingysam commented 3 months ago

Huh interesting, so you're using Christmas Community as a recommendation list? Like you add books that you think other people should read to your wishlist?

fdw commented 3 months ago

It's more a recommendation for me: I use it to organize ideas for my next books. I add everything that sounds interesting, and I ask people to have a look and recommend what they've read. And when I need something new, I choose from that list.

Wingysam commented 3 months ago

Are you able to see the books they add to your list?

fdw commented 3 months ago

No, but it's not so much about them adding new things. In a sense, I maintain my personal "wish" list and ask for feedback like "What do you think I should read next?"

Wingysam commented 3 months ago

So it sounds like we need a few concepts:

fdw commented 3 months ago

Some thoughts, just from my perspective (but you have thought a lot more about Wishlist, so please just take them as food for thought):

Wingysam commented 2 months ago

I'm having trouble envisioning some of this from a user perspective. If Bob has shared multiple wishlists with me, what will that look like on the front page? Does each wishlist have a name? Can I see who it has been shared with? Can it be shared with entire groups in addition to individual users?

fdw commented 2 months ago

If it were me, I'd try to keep it simple for the beginning and then see what can be improved. For example, I wouldn't use groups at all for now - that's something that can be implemented independently later.

A name for a wishlist probably makes sense. Then you can see if this one is for their birthday or some other event, maybe even just a note.

Seeing who the list has been shared with is probably also helpful, because I can already see who has claimed a gift, can't I? It's definitely not something that has to be kept secret, so why not?

dathbe commented 2 months ago

The ability to set a list (or individual items) as private would be great too. I keep some things as a reminder to myself that the whole fam doesn't need to see.

Wingysam commented 3 weeks ago

I think private items is out-of-scope for Christmas Community. I want to avoid complicating the UI with features that most people don't use. If we build lists that you can share with arbitrary people then you could create a private list by just not sharing it with anyone though!