search

Wingysam / Christmas-Community

Christmas lists for families
GNU Affero General Public License v3.0
245 stars 41 forks source link

Discussion: logged in user sees ???/??? on wishlists overview #88

Open dbarenholz opened 1 year ago

dbarenholz commented 1 year ago

When you are logged in to some account, it shows ???/??? statically rendered through the WISHLISTS_COUNTS_SELF variable in a language js file. In below image, I am logged in as dan. image

Would it make more sense to replace ???/??? with ?/X, where X is the total of my own list? This is information that I know. What are your thoughts?

Wingysam commented 1 year ago

Someone else can add items to your wishlist and most people probably don't want to know how many items people have put on their list. Maybe it can show how many items specifically your user has added?

dbarenholz commented 1 year ago

Right - I've just "suggested" a bunch of items with user1 for user2, and they don't show up when logged in as user2. That makes the ? more indicative, as you don't know if others have added anything.

Showing how many items I have added to my own list makes sense. But does it make more sense than a ??

Wingysam commented 1 year ago

I think ?/<how many items you've added to your own list> makes the most sense. I'll leave this open until that's implemented. Thanks for bringing this up!