search

Winniehyx / pe

0 stars 0 forks source link

Error message not clear. Should say that the front part(local part) of the email should not be empty #14

Open Winniehyx opened 3 years ago

Winniehyx commented 3 years ago

add n/John Wayne p/88765432 e/@example.com a/John street, block123, #01-01 b/1998 07 10 image.png

nus-pe-bot commented 3 years ago

Team's Response

The error message while not extremely detailed, it already indicates that the email should be in proper format, missing a username should be obvious error for the user

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Error messages are supposed to be detailed. It does indicate that the email should be in proper format but users might not know what constitutes a "proper format". You cannot simple assume that users would type the correct thing. In addition, a case whereby the user does not want to put the local part of the email(not username by the way) would be that they do not want to give up the details for their email. An appropriate error message would include local-part should not be empty. In fact, I down-played the severity and I personally feel that severity would be medium as the error message is not elaborate enough.

:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FeatureFlaw]

Reason for disagreement: This is a feature flaw. Documentation bug refers to those written.