WinterSquire / AlphaRing

A Modding Tool For MCC
MIT License
146 stars 2 forks source link

H2A splitscreen broken #29

Closed geomusicmaker closed 2 months ago

geomusicmaker commented 3 months ago

Hi,

Firstly, thank you for making this mod. You have no idea how happy I was to find it and make the possibility of playing with my partner possible. Why they didn't include this in the official release when all of the capability is there is insane.

Anyway... for the most part this mod is working flawlessly for me. However, I've found that H2A doesn't work as expected. See below: h2a broken 2

But if I hit TAB to go back to classic, it works fine. H2c normal 2

It looks like player 2's camera is being stretched across the entire screen as the HUD for both players is still correct and present. I see a similar issue has been raised by someone on a steamdeck but this is on PC. Is this a known bug or am I finding something new?

Nethseaar commented 3 months ago

Same experience for me. 2-player works fine using the mod, but 3- or 4-player puts player 1's view into fullscreen with the separator lines and HUDs of the other players over the top. Playing on PC, via Steam, not using Steamdeck. 1 Logitech controller, 2 XBox PowerA controllers, plus mouse and keyboard.

20240629185247_1 20240629221609_1

Going into classic fixed it for players 1-3, but player 4's screen was black.

Jack-Culcasi commented 2 months ago

For me H2A (MCC, Steam, PC) works perfect but the cinematics are not centred on the screen

WinterSquire commented 2 months ago

According to my research, the splitscreen code for anniversary graphic is hard-coded to 2 players. So this issue is probably not gonna be solved.

geomusicmaker commented 2 months ago

According to my research, the splitscreen code for anniversary graphic is hard-coded to 2 players. So this issue is probably not gonna be solved.

I'm not trying to get more than two players though. It is only one players camera stretched across the two split screen panels which isn't right.

WinterSquire commented 2 months ago

Oh sorry, I didn't notice that. Normally 3/4 splitscreen players would cause that. I just pushed a new commit trying to fix that. Can you test the dev build to see if that works?

Dragneel276 commented 2 months ago

Dev Build seems to work for me, H2A now properly scales across in 2 player co-op (at least in my brief testing) Screenshot 2024-07-26 230201

also the scoring hud is kinda wack, not sure if that's even a fixable bug at this point (probably not too important yet)

Curiously, the original issue is still kinda prevalent in 4 player co-op, as 2 POVs are now being stretched, instead of only one. Screenshot 2024-07-26 230708 ^^ Halo 2, working fine? (this is so cool dude)

Screenshot 2024-07-26 230658 ^^ H2A working less fine, with a lot of texture pop-in. (among other issues lol)

geomusicmaker commented 2 months ago

OK, so this new build has fixed the initial problem of one player's camera being stretched across two. However, there are now control issues.

For context, Player 1 is using K/M and Player 2 using controller testing on Outskirts.

All is fine until Player 2 shoots using controller. From that point, Player 1's fire controls on the mouse go dead and only comeback by disabling the mod, shooting, and then re-enabling, but as soon as Player 2 shoots again, it reverts to broken. For some reason it also seems to hold down the fire command when I switch weapons (see the SMG in the video) I can create a separate issue for this if it helps?

Update: Recorded a video with an input overlay so you can see what I mean. https://streamable.com/vlp1tc

WinterSquire commented 2 months ago

control issue solved

geomusicmaker commented 2 months ago

Amazing work! Thank you so much :)

WinterSquire commented 2 months ago

No problem, if you don't have any other questions with this issue, please close it. ☺️