search

WinterTechForum / skybar

Skybar: Live code coverage engine
11 stars 3 forks source link

Handle inner classes #9

Closed marshallpierce closed 9 years ago

marshallpierce commented 9 years ago

Perhaps sufficient application of getDeclaringClass() / looking for what classes have source available would do it.

eirbjo commented 9 years ago

I tested this by adding a PostHandler inner class to the MessageServlet class. Seems to me mapped fine to the MessageServlet.java source file name just fine. Is this just working, or did you think about supporting inner classes at some other level?

marshallpierce commented 9 years ago

I hadn't tried it at all, but that's awesome that it works. :) Right now we're filtering classes with "$$" out; I'd like to make that more robust by seeing whether or not we can find the sources at instrumentation time so we can avoid the overhead if we can't usefully show it anyway.

marshallpierce commented 9 years ago

In what I have to assume was a moment of altitude-induced insanity, I didn't correctly follow the logic of how we get notified of visiting a source file and how that translates into the registry. So, I think this is a non-issue.