search

Wintergatan / Midi-to-laser-cutter

https://wintergatan.github.io/Midi-to-laser-cutter/
MIT License
126 stars 16 forks source link

#21 Correct and add scales in scaleandmusicbox.js #21

Closed weirdsound closed 7 years ago

weirdsound commented 7 years ago

The naming scheme used for the scales in scaleandmusicbox.js is incorrect. The list of scales needs to be extended.

djflorio commented 7 years ago

@weirdsound which scales are named incorrectly? All I see is that Phrygian is spelled incorrectly (unless that's an alternate spelling?)

Are you saying that some of those modes don't match up with the intervals presented? I haven't personally checked all of them, so I'm not sure, but the few that I've checked seem correct.

weirdsound commented 7 years ago

@djflorio Not the scales themselves. The categories. E.g. "aeolian" is certainly not a major scale. I'm preparing a more comprehensive list containing about 90 scales (including chromatic, various pentatonic, etc.). Feel free to join the discussion over at [http://gitter.im/Wintergatan/Midi-to-laser-cutter]