Closed trygve55 closed 4 years ago
Thanks for the patch.
Have you tested the scalability of this? I mean, in a launcher with many ROMs have you noticed a decrease in performance? Instead of calling xbmc.getCondVisibility() many times for each ListItem it could be better to call it once and keep the result in a bool variable.
I have not tested with over 11 items in the directory. It sounds like calling it only once would be better for performance. Do you mean calling it once every for every "gui_render" or once and saving it as a global variable? If saved as a global variable it would need to be updated for the kiosk mode setting to take effect. Maybe calling it inside "_command_render_root_window" and updating the global variable?
OK, I will merge now. If I detect scalability problems then I will unroll the call to xbmc.getCondVisibility()
.
Disabled context menu when the skin setting kiosk mode is set to true.