Wintermute0110 / plugin.program.AEL.dev

Emulator frontend and app launcher for Kodi
GNU General Public License v2.0
105 stars 36 forks source link

Extraction of settings access into own module #130

Open leonsbane opened 3 years ago

leonsbane commented 3 years ago

Hi,

thank you very much for creating this addon.

The changes in this PR are refactoring the settings access from inside the code by creating a module which can be imported when needed. I wanted to make the access somewhat more global and a bit safer. This also removes the necessity to pass the settings as an argument to other modules.

It's not fixing anything, but maybe you still might be interested.

Wintermute0110 commented 3 years ago

Hi,

Thanks for the effort you did in making this. I will not merge this yet. I am still thinking about the future of AEL, either to move to a pure functional approach like AML of continue the object oriented model currently in master. Please keep the PR for the time being.