Wintermute0110 / plugin.program.AEL.dev

Emulator frontend and app launcher for Kodi
GNU General Public License v2.0
105 stars 36 forks source link

Computing checksum is awfully slow #135

Closed Hybrid512 closed 3 years ago

Hybrid512 commented 3 years ago

Hi,

I'm trying to use ScreenScraper in order to scrap metadata only but the process is very very slow and it hangs at that point :

2021-05-31 22:17:33.412 T:2107     INFO <general>: AEL DEBUG: Scraper.clear_cache() Clearing caches "Asterix & Obelix XXL.iso" "Nintendo GameCube"
2021-05-31 22:17:33.413 T:2107     INFO <general>: AEL DEBUG: ScreenScraper.get_candidates() rompath      "/data/emulation/ROMS/gc/Asterix & Obelix XXL.iso"
2021-05-31 22:17:33.413 T:2107     INFO <general>: AEL DEBUG: ScreenScraper.get_candidates() romchecksums "/data/emulation/ROMS/gc/Asterix & Obelix XXL.iso"
2021-05-31 22:17:33.413 T:2107     INFO <general>: AEL DEBUG: ScreenScraper.get_candidates() AEL platform "Nintendo GameCube"
2021-05-31 22:17:33.413 T:2107     INFO <general>: AEL DEBUG: ScreenScraper.get_candidates() SS platform  "13"
2021-05-31 22:17:33.413 T:2107     INFO <general>: AEL DEBUG: _get_SS_checksum() Processing "/data/emulation/ROMS/gc/Asterix & Obelix XXL.iso"
2021-05-31 22:17:33.413 T:2107     INFO <general>: AEL DEBUG: _get_SS_checksum() File is not ZIP. Computing checksum of whole file.
2021-05-31 22:17:33.413 T:2107     INFO <general>: AEL DEBUG: Computing checksums "/data/emulation/ROMS/gc/Asterix & Obelix XXL.iso"

Looks like the checksum computation is very slow at least for these GameCube roms that are quite big (>1.5GB). Can't this be optimized ? Scraping with TheGamesDB scraper is ways faster but I can't get French metadata with it :/

Wintermute0110 commented 3 years ago

Computing the checksum is already optimized, well... most things in AEL are already quite optimized :) If you use ScreenScraper it is mandatory to compute the checksum even for ISO images and that's going to take time no matter what. I recommend that you use TGDB or MobyGames for ISO-based platforms, or just be patient.

Also, I notice that you use ISO for GameCube. I strongly recommend to use the new RVZ format and CHD for Retroarch-supported emulators. More information about RVZ here.

Hybrid512 commented 3 years ago

Hi, thanks for the tip, I was unaware of the RVZ format ... converting my ISOs right away ;)

Ok, so this can't be fixed, I'm closing it.