Latest Version of IITC-CE Broke TotalRecon

[fortepc]

Inside the UI of IITC Nothing happened when I tried to load totalrecon today, so I tried to use the clear script and it did come up and let me re-do the script url, but still after that nothing happened, so I did a little more digging in the browser's console.

On Click this happens:

On Refresh where there should be TotalRecon tiles this happens:

If I click any of the debugger links this is what I see:

I disabled the IITC-CE and re-installed the IITC.me branch and it worked fine, I'm not sure what they changed but wanted to make sure you're aware of it. I'll switch to the IITC.me fork in the meantime when I need to use TotalRecon, thanks again for this plugin, it's awesome!

[fortepc]

I see they just made some new changes, not sure what may have caused this though. https://github.com/IITC-CE/ingress-intel-total-conversion/commits/master

[jwadamson]

commit 67f4dfab18d3231a0c33cc5e52d3f1e4858d6fd1 of IITC-CE removed window.createGenericMarker function.

I can't really trace the few commits touching that file to figure out what equivalent call would be.

[jwadamson]

window.plugin.totalrecon.createGenericMarker = function(latLng, color, opts) { opts.color = color; return L.marker(latLng, opts); };

/ update the two other references tocreateGenericMarker to this absolute reference /

handling of "color" is almost certainly incorrect, but that gets some sort of marker to show up and seems to make the plugin semi-functional.

[Wintervorst]

Copied the original implementation from IITC to master version of totalrecon. Could you check if this 'fix' works on IITC-CE? If so, I might update my other plugins with the same solution to make them compatible with IITC-CE again.

[Wintervorst]

Closed this issue. Works on the latest desktop version 0.29.1.20190518.145617. I'll update my other plugins with this change somewhere during the next week.

[jwadamson]

working great for me now, looking good, thanks!!