Winwardo / solid-octo-disco

Topher and Vasily's Intelligent Web Assignment
0 stars 0 forks source link

QuotedTweet Timeout so not forever loading #138

Closed VasilyShelkov closed 8 years ago

VasilyShelkov commented 8 years ago

shouldn't use in src/client/results/Feed.js:231

getInitialState() {
   return {
     tweetContent: null,
   };
}

instead see https://facebook.github.io/react/docs/reusable-components.html#es6-classes in particular the constructor part of it.

Also after some time, we should just show an error screen that the fetch from twitter failed.

Winwardo commented 8 years ago

So the only time we'll see this is if we have a quote within a quote. This can be more easily solved by simply adding a "isQuote" prop to and not allowing it to attempt to show its own quote if it is already one itself.

VasilyShelkov commented 8 years ago

This has been fixed by using constructor in Quoted Tweet