search

Wiqaytna-app / wiqaytna_android

GNU General Public License v3.0
161 stars 65 forks source link

more details about getting started in readme #6

Closed IhabBendidi closed 4 years ago

IhabBendidi commented 4 years ago

Build cannot work without gradle properties file. It was ignored through the .gitignore file. It was corrected here, with the added gradle properties file using the data about it in the Readme.md and the correction in the .gitignore

medyo commented 4 years ago

@IhabBendidi I prefer not to includegradle.properties in the project, it might contain sensitive variables that can't be shared with everyone or even some user environment variables. I think it's up to the developer to include it manually by reading the readme

DouiriAli commented 4 years ago

The gradle.properties file should be out of version control, because developers may use it to customize builds without impacting the other build environments.

IhabBendidi commented 4 years ago

@DouiriAli @medyo That is completely true. The motivation though was that there are some not very android knowledgeable people wishing to build it, with them not connaisseurs enough to know where to add it. Another option is to explain it further in the Readme.md file, as its not explained enough

IhabBendidi commented 4 years ago

Added some explanation details on readme.md

AnasSoukrat commented 4 years ago

You can keep gradle.properties in your project and use the $HOME/.gradle/gradle.properties for sensitive data