Why the fork relationship was not maintained?

Wiqaytna-app / wiqaytna_android

GNU General Public License v3.0

161 stars 65 forks source link

Why the fork relationship was not maintained? #7

Closed ezzarghili closed 4 years ago

ezzarghili commented 4 years ago

It is clear that the app is a fork of https://github.com/opentrace-community/, why the fork relationship was not maintained with original repository?

iothmane commented 4 years ago

It's probably due to the fact that everything was pushed to GitHub this morning as the commit history shows.

ezzarghili commented 4 years ago

@iothmane why would that be the reason for not maintaining the the fork relation with the original repo? the original repo initial commit is from two months ago, they could have forked and applied all their patches to the fork.

This would make it easy to pull in upstream fixes
They could easy contribute changes to upstream
People can easily check diffs and changes made by this repo
This would make it clear that the original work is done by third party and not as stated in the official website see https://github.com/Wiqaytna-app/wiqaytna_android/issues/10

iothmane commented 4 years ago

@ezzarghili i'm all in for maintaining the fork for all the reasons you listed ! It's just from what I noticed they probably downloaded the source code worked on it and pushed everything this morning so it's just a "GitHub setup flow" error 🤷🏽‍♀️! But for sure i hope they restore the link if it's even possible 🤔

ezzarghili commented 4 years ago

@iothmane Yes understood, my point was just about best practice (also points stated above) :)

AmiZya commented 4 years ago

Anyone tried to diff the two repos the see what was exactly changed?

ElMostafaIdrassi commented 4 years ago

Here is the diff between the master branches. Here is the list of added files by wiqaytna.

ezzarghili commented 4 years ago

Issue clarified by Zouheir LAKHDISSI in https://www.facebook.com/geeksblabla/videos/184114139689813/UzpfSTEyMjcwNDQ1MTY6MTA2NjY2NzM4MDQwMTkwNQ/ Mainly, people creating the repo (not the actual developers?) were not aware of the implications of this. At this point I am closing this in favour of https://github.com/Wiqaytna-app/wiqaytna_android/issues/23 and defining a process on how upstream/downstream changes are handled.