jvikstrom
commented
6 years ago So this is way to unwieldy to actually do a code review of. Just add a script that runs linting on travis and when it passes the travis build the PR will be approved.
(You'd have to add a line to .travis.yml at line 7 that runs the shell script for linting)
This for instance is how the script that runs linting for the backend looks like: `
!/bin/sh
cd backend;
if gulp eslint; then echo "Passed linting" else exit 1; fi
if gulp test; then echo "Passed linting" else exit 1; fi `
Line 6 runs the shell script for linting and testing the backend. Do something similar for the frontend.
If you've got npm on the frontend you could just use gulp and eslint (requires a gulpfile. look at backend/gulpfile.js), otherwise I've got no idea :)
shrew97
Solved issues #7 , #8 , #14
Fetches anomalies from a realtime database and marks the anomalies with a different color when they're new or something changed in the database (doesn't need to be a color change, but some sort of user notification is required). Anomaly description available when anomaly is pressed (as well as a box that shows that anomaly is targeted). Red circle that displays our data-boundary so our users know where it's "common" for anomalies to dissapear and reappear. Locked camera zoom and location.