A "threshold maker" aka fake noise filter is needed

WireCell / wire-cell-gen

Wire Cell packages that can generate things like wires, cells, depositions, diffusions, slices, frames, ...

0 stars 1 forks source link

A "threshold maker" aka fake noise filter is needed #20

Closed brettviren closed 6 years ago

brettviren commented 6 years ago

The NF component makes a threshold array for the output frame traces. This array is required by SP components. In order to run SP on input frames which do not require NF, this threshold array must be produced. The threshold maker should forward the input traces to the output frame so little new memory is consumed.

brettviren commented 6 years ago

This component is somewhat suspect. If the full NF is not applied to the simulation it means that the same modifications to the signal that is done to real data will not be performed. Naively one thinks that a "null" NF is needed but actually it would be "bad". This issue will be kept open in case there is dissenting views but for now it is removed from 0.8.x project.

brettviren commented 6 years ago

This issue is a misconception. The NF does not produce any thresholds but rather fills the channel mask maps with "bad" channels. NF is not mechanically required to be run on sim so that SP may run.