search

WireGuard / wgctrl-go

Package wgctrl enables control of WireGuard interfaces on multiple platforms.
https://godoc.org/golang.zx2c4.com/wireguard/wgctrl
MIT License
753 stars 84 forks source link

wgtypes: Peer bytes types #8

Closed bradfitz closed 6 years ago

bradfitz commented 6 years ago

https://godoc.org/github.com/mdlayher/wireguardctrl/wgtypes#Peer has

    ReceiveBytes                int
    TransmitBytes               int

Are those counters of received and transmitted bytes? If so, they should be int64. (Go's default unit for sizes for things that aren't in-memory sizes.)

In any case, docs would be nice.

mdlayher commented 6 years ago

SGTM for int64, that's an easy change.

Yeah, docs to come on some of the older types for sure.

mdlayher commented 6 years ago

Fixed in https://github.com/mdlayher/wireguardctrl/commit/3fc743e647482f1f60c277c20f520b5339b5088d.

mdlayher commented 6 years ago

Updated docs as well: https://godoc.org/github.com/mdlayher/wireguardctrl/wgtypes#Peer.