search

WireMock-Net / WireMock.Net-docker

WireMock.Net-docker is a Docker image which runs WireMock.Net (a flexible library for stubbing and mocking web services)
MIT License
22 stars 6 forks source link

update Dockerfile with dotnet 5.0 #29

Closed ibmer921150 closed 3 years ago

ibmer921150 commented 3 years ago

Hi there,

I am aware of the change commit 8b6ed9013611a97b2f1844bcf1148155eaa31204, the .net has been upgrade to 5.0 from 3.1. The dockerfile should be updated accordingly. If I still use the dotnet core 3.1 in the dockerfile. The build can be successfully. But the docker run will fail as below error with dotnet compatibility issue.

Commandline arguments are invalid. WireMock.Net cannot start.

Note that the dotnet core runtime only support Ubuntu 20 https://hub.docker.com/_/microsoft-dotnet-aspnet

Happy to discuss.

Thanks Yu

ibmer921150 commented 3 years ago

I have no chance to test the dotnet core 5.0 yet, the pull request would be a suggestion

StefH commented 3 years ago

Hello @ibmer921150,

Thanks for reporting this.

The issue about Commandline arguments are invalid. WireMock.Net cannot start. was this error: https://github.com/WireMock-Net/WireMock.Net-docker/commit/6b830f933394f1ee643031c75fad3d5c15fc9881#diff-6fbe11e848adfb7fc51116ca7809038ec1a2f769c9db9055e7d1fa427a874aedR15

However upgrading Linux to .NET 5 is a good idea.