search

WireMock-Net / WireMock.Net

WireMock.Net is a flexible product for stubbing and mocking web HTTP responses using advanced request matching and response templating. Based on the functionality from http://WireMock.org, but extended with more functionality.
Apache License 2.0
1.35k stars 197 forks source link

Made changes to accommodate breaking change in testcontainers-dotnet 3.9 #1127

Closed epDugas closed 5 days ago

epDugas commented 5 days ago

Made changes to accommodate breaking change in testcontainers-dotnet 3.9

3.9.0 1146 1100

StefH commented 5 days ago

Made changes to accommodate breaking change in testcontainers-dotnet 3.9

Ref: testcontainers/testcontainers-dotnet#1100

Is this for sure a breaking change?

epDugas commented 5 days ago

Made changes to accommodate breaking change in testcontainers-dotnet 3.9 Ref: testcontainers/testcontainers-dotnet#1100

Is this for sure a breaking change?

Yes, added relevant urls to pr description.

StefH commented 5 days ago

Ok. Thanks for the heads-up.

This is not the first time they introduce a breaking change in a minor version.

Is there a better way to handle this? Or is it only feasible to fix it like this PR?

epDugas commented 5 days ago

Ok. Thanks for the heads-up.

This is not the first time they introduce a breaking change in a minor version.

Is there a better way to handle this? Or is it only feasible to fix it like this PR?

Yeah, I saw you had to pin to 3.7. There may be a better way, but I didn't see an obvious one. I just made the change match the changes that were made to all of the included ContainerBuilders.