Should there be a .NET 5.0 target now?

WireMock-Net / WireMock.Net

WireMock.Net is a flexible product for stubbing and mocking web HTTP responses using advanced request matching and response templating. Based on the functionality from http://WireMock.org, but extended with more functionality.

Apache License 2.0

1.41k stars 209 forks source link

Should there be a .NET 5.0 target now? #541

Closed gitfool closed 3 years ago

gitfool commented 3 years ago

After porting projects to .NET 5.0, unit and integration tests using WireMock.Net seem to work fine, apart from logging "WireMock.Net server using .NET Core 3.1". Not sure when it's needed but I noticed there are a lot of target frameworks for some reason:

Specify:

<TargetFrameworks>net451;net452;net46;net461;netstandard1.3;netstandard2.0;netstandard2.1;netcoreapp3.1</TargetFrameworks>

Also, some of those are now well out of support and so could possibly be dropped?

StefH commented 3 years ago

https://github.com/WireMock-Net/WireMock.Net/pull/543

StefH commented 3 years ago

Hello @gitfool,

Can you explain this: WireMock.Net seem to work fine, apart from logging ?
Some frameworks are indeed out of support, however for now I keep these. Probably next year I will remove some.

gitfool commented 3 years ago

@StefH the logging comes from the hard wired log message determined by target framework at compile time (AspNetCoreSelfHost .RunHost), which you address in PR 543 along with a few other tweaks that make me think a new release with net5.0 target framework is advisable.

StefH commented 3 years ago

OK. PR is merged