Wirecloud / docker-wirecloud

🐳 Docker Official Image packaging for WireCloud https://conwet.fi.upm.es/wirecloud
Other
8 stars 14 forks source link

[MUST] Dockerization must protect Username/Password ENV #32

Closed jason-fox closed 5 years ago

jason-fox commented 5 years ago

With the addition of Oauth2 support authentication with using FIWARE Keyrock, usernames and passwords are now part of the Docker environment variables. Currently these can only be passed using plain text. The addition of Docker Secrets support protecting these passwords is necessary to plug a potential security flaw.

This is a simple addition of a script in the same manner as PostGres (and relevant documentation of course) Cygnus and most of the IoT Agents does it already.

https://github.com/telefonicaid/iotagent-node-lib/pull/726#discussion_r242214046

Within the Docker container, Passwords etc can only be passed protected by Docker Secrets