search

Wirecloud / wirecloud

Widgets Container and Mashup edition tools. Reference implementation of the FIWARE Application Mashup GE
https://wirecloud.rtfd.io/
Other
60 stars 45 forks source link

Tigalab #474

Open tigalab opened 4 years ago

tigalab commented 4 years ago

This pull request contains the improvements made by the Tiga for Wirecloud. These improvements are part of the fiQare project, which is based on ISO 25010 to improve software quality. More info: https://fiqare.eu/

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-28.5%) to 53.372% when pulling 0b9ec235051df1231acc521e05a09a23745e9c87 on tigalab:tigalab into 1ddcf1b7fb23e6613194dde5287cb5b9089f7b19 on Wirecloud:develop.

aarranz commented 4 years ago

Hi @tigalab,

Thank you very much for your contributing into WireCloud.

However, I've to say that the PR is very large and I don't know what are the advantages of applying it. Can you elaborate it?. Also, it may be a good idea to split it into several PRs.

Best Regards, Álvaro

tigalab commented 4 years ago

Hi @aarranz ,

I am grateful for your review, thank you very much,

This PR contain some minor code improvements which is made by a tool. This why this PR seems very large however i can not say it is a big problem these are just small code corrections but i am going to seperate these to 3 part.

It also might be a little big but i think it will be much better for you.

Our best compliments, Tigalab.