Wirecloud / wirecloud

Widgets Container and Mashup edition tools. Reference implementation of the FIWARE Application Mashup GE
https://wirecloud.rtfd.io/
Other
60 stars 45 forks source link

Popover improvements #509

Closed aarranz closed 3 years ago

aarranz commented 3 years ago

Proposed changes

This PR makes some improvement on how Popovers are managed by WireCloud. Main improvement is management of the popover visibility now that we are allowing sticky popovers, as those popovers are not closed on click events, they were remaining in the user interface when moving between tabs, sections and so on, when closing widgets, .... This PR makes WireCloud aware of the widget visibility and hides/displays the popover when required and removes them on widget unload. This PR also fixes some problems when enabling/disabling fullscreen mode and some problems repainting them.

Types of changes

What types of changes does your code introduce to the project: Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

N/A

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.06%) to 88.743% when pulling 43c32d2e8c9a470503cfb390d35a5a3585108a57 on aarranz:feature/no-pointer-events-popover into cdcdddda00281fde3746ed48d303bc24d6ed1760 on Wirecloud:develop.