search

Wiredcraft / dopy

Digital Ocean Python
MIT License
95 stars 62 forks source link

Always return the public IP address of the droplet #28

Closed deivid-rodriguez closed 9 years ago

deivid-rodriguez commented 9 years ago

Right now the type of IP is inconsistent. If no private_networking is specified when creating the droplet, it will return a public IP. Otherwise it will return a private IP (because private IPs are listed first by digital_ocean's API, and we are just returning the first element in the json response).

deivid-rodriguez commented 9 years ago

Anybody there?

Xowap commented 9 years ago

I had the same issue, I can only :+1: this

cvallance commented 9 years ago

Sorry, only noticed this pull request after I had already duplicated the effort. https://github.com/Wiredcraft/dopy/pull/33

Not a great outlook if this pull request has been sitting here for a while... I kinda need it for some ansible stuff.

zbal commented 9 years ago

Merge #33 instead to include private_ip_address as well. Thanks !