Replace basestring with str type to support Python3

Wiredcraft / dopy

Digital Ocean Python

MIT License

95 stars 62 forks source link

Replace basestring with str type to support Python3 #55

Open srkiNZ84 opened 7 years ago

srkiNZ84 commented 7 years ago

Python3 does not have a "basestring" type (as per: https://stackoverflow.com/questions/34803467/unexpected-exception-name-basestring-is-not-defined-when-invoking-ansible2) and the recommended action is to replace it with the "str" type.

This was the only instance of it that I managed to find in the repository.

Issue(s): None

ghost commented 7 years ago

DakotaNelson commented 6 years ago

Is there any chance this could get merged any time soon?

jbaublitz commented 6 years ago

Hey there, Ansible is currently using dopy for their Digital Ocean modules. Is there any way we can get this fix published? Currently even trying to create a droplet from Python3 throws an exception.

ioggstream commented 4 years ago

ping :)

srkiNZ84 commented 4 years ago

I haven't got the permissions to merge this PR and it looks like the repository hasn't been committed to since 2016. Think the Ansible module might need to change the dependency or find a different DigitalOcean library to use.

ioggstream commented 4 years ago

@srkiNZ84 we can get in touch with wirecraft or ask to pypi to provide another source for the package distribution...